From owner-freebsd-bugs@FreeBSD.ORG  Sat Feb 14 19:20:03 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 48F3F16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 14 Feb 2004 19:20:03 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2C81343D1F
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 14 Feb 2004 19:20:03 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i1F3K3bv060444	for <freebsd-bugs@freefall.freebsd.org>;
	Sat, 14 Feb 2004 19:20:03 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i1F3K3U8060443;
	Sat, 14 Feb 2004 19:20:03 -0800 (PST)
	(envelope-from gnats)
Resent-Date: Sat, 14 Feb 2004 19:20:03 -0800 (PST)
Resent-Message-Id: <200402150320.i1F3K3U8060443@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Pierre-Luc Lespérance <oksala@videotron.ca>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6E60016A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat, 14 Feb 2004 19:12:48 -0800 (PST)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6AACB43D1D
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat, 14 Feb 2004 19:12:48 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i1F3Cm72081816
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat, 14 Feb 2004 19:12:48 -0800 (PST)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.10/8.12.10/Submit) id i1F3Cl1j081815;
	Sat, 14 Feb 2004 19:12:47 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200402150312.i1F3Cl1j081815@www.freebsd.org>
Date: Sat, 14 Feb 2004 19:12:47 -0800 (PST)
From: Pierre-Luc Lespérance <oksala@videotron.ca>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.0
Subject: kern/62862: pcm vchans related crash
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Feb 2004 03:20:03 -0000


>Number:         62862
>Category:       kern
>Synopsis:       pcm vchans related crash
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 14 19:20:02 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Pierre-Luc Lespérance
>Release:        4.9-p2
>Organization:
N/A
>Environment:
FreeBSD silence 4.9-RELEASE-p2 FreeBSD 4.9-RELEASE-p2 #57: Sat Feb 14 21:32:13 EST 2004     silence@silence:/usr/src/sys/compile/oksala  i386
>Description:
The system hangs if a pcm vchan is closed while it is in use. My fix simply check if some vchans are in use. 
>How-To-Repeat:
- Play a sound on a vchan
- set vchan to 0 with sysctl sysctl hw.snd.pcm0.vchans=0
>Fix:
--- sound.c.orig        Sat Feb 14 22:09:31 2004
+++ sound.c     Sat Feb 14 22:08:00 2004
@@ -810,11 +810,17 @@
        d = oidp->oid_arg1;

        pcm_lock(d);
+
        cnt = 0;
        SLIST_FOREACH(sce, &d->channels, link) {
                c = sce->channel;
                if ((c->direction == PCMDIR_PLAY) && (c->flags & CHN_F_VIRTUAL))
                        cnt++;
+                if (c->refcount > 0) {
+                        pcm_unlock(d);
+                        return EBUSY;
+                }
+                
        }
        oldcnt = cnt;
        newcnt = cnt;

>Release-Note:
>Audit-Trail:
>Unformatted: