From owner-svn-src-all@FreeBSD.ORG Mon Aug 18 19:27:32 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E8605A4C for ; Mon, 18 Aug 2014 19:27:32 +0000 (UTC) Received: from nm8-vm0.bullet.mail.bf1.yahoo.com (nm8-vm0.bullet.mail.bf1.yahoo.com [98.139.213.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 877D03BDB for ; Mon, 18 Aug 2014 19:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1408390044; bh=kV/FT6R8mpByBuWhYd00+IrXEu0c8SPYDFdN7i/em3s=; h=Received:Received:Received:X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=tH5jQmG7bT+YkaIt83CALQeDg8z44zi9zWEef3Q/mnuR4lfVn1PaTHpu2dS0jcpwFexa1DJvMjrzeB8QGbiNEEj8c7uK/774LnjSKVzvVYF+En7UjCD0JS4I/cuFNAuHtM93YvFAG/mcGSgYoIBcQbaEJ1tAz/v0Fr10Q44t2DI7LcS6O9kDhbN29q8pvtgTm2id6FTs2UR6VZNjGr07gmdClz3ByIyJWohj/MjmdtZxioPmW2RPwTq2EGXkSQV9gCYs99j/jvherz4xlibQpSe5j8Zcyvm2GgUr8Hs2vpALTm7bTvM/Osi6ZrnWH9ZBdgGOM+W8qxPrD7FIu4WieQ== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.com; b=Mla3bClQV86afFlPA7LFdlK8mRgD1Wpj+U/Pfvtao/YwcH4NRmgeZFBNLz/CHK9Qy57llACoQZ4jz/QNp8uQP5rJDfFzNmRD16svUf1K2ttagGE8bITmqdi9qRJsy0rOD0SsiKTgOgPmFPfFj+mx9nqRHBSE+FCs7+47D9ZtCVUNfFvUdj7nvM5npLQr9u7me1qYVVewA6l6ocdxWBWTSr1mFWADWOb38KZ96vA28pj43YYsONse4pMnviccHws1iqgaqLIsJN53cr3LNxlv+apEjDWVQIcKzIdHejvJ3BEvhQ2GSi29pfE4ryVj+bQAAAvH5BK8TaYEvYtdQfsa9g==; Received: from [66.196.81.171] by nm8.bullet.mail.bf1.yahoo.com with NNFMP; 18 Aug 2014 19:27:24 -0000 Received: from [98.139.213.9] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 18 Aug 2014 19:27:24 -0000 Received: from [127.0.0.1] by smtp109.mail.bf1.yahoo.com with NNFMP; 18 Aug 2014 19:27:24 -0000 X-Yahoo-Newman-Id: 723978.36447.bm@smtp109.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 4tpeMsEVM1kPB1ZEEiV_i.1GHIh8EgFAeVegL91mtTboJFm W9VOZTrxvwcf7ChQpbXet0bJxbelWOeYm7UiPyDoN.7t0KPW.6wbCKjblM49 _F82wsF6beU6aj6XmPWsDsoy0qDtAtRiAELPzjDGf_uc9nCL4G4z_IQvDYaG xiwufNWakqr4e41QAuvtXXgOf3HdMf1HHs7HkUFu3.aitnpQ3327TJtiajKk M3FuzQxiw8vP.tsAPPaDvuozDEyDRnKFbAS_lqAm4qFg45.HVaSB9mo7bIRa 9LHUJmlA0W9nAoiIt8AVUgY1raLDryX_UD7u0mbKUhFfmkBjyACwjdyF6W6t 1WnuJMjPab30Csl01puZMk9QFGvuQhnfmuFnljwD7ksC1a6LXFkDZbg0fQcI lWQR7STFDp34LZ6hUAqzXaIivqwNN5JT9ln5UGozUErxJcBzc3EnAblJ8aW0 ODEbZsRAg71Lt6P6i4UwIGGGxgKaSutFSRuCKMPYt7.yb.nf_ytg5I9dQm3i fR9u.b4VOaIrUoiar.IdzfdAM8xUeCSA9WRlwaP37AzC_r4gz1kswxZLm0N9 pO4oe1z7TAAl5_Hcfw5ZCQmwu8916F0pOyUHdLlpSJwa7FTl8o5ikVI9Jbg4 AYxLZ17W2kZ9LZQJejBelYAkil3k- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <53F25399.40204@freebsd.org> Date: Mon, 18 Aug 2014 14:27:21 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Dimitry Andric , Alexey Dokuchaev Subject: Re: svn commit: r270099 - in stable: 10/contrib/gcc/config/i386 9/contrib/gcc/config/i386 References: <201408171308.s7HD8Fnh099147@svn.freebsd.org> <20140817131942.GA38672@FreeBSD.org> <8CA269F6-BCD2-4E78-947F-682214367F36@FreeBSD.org> <20140817134509.GA47327@FreeBSD.org> <9181921C-43BB-48C9-B63D-7C6F99D7A763@FreeBSD.org> In-Reply-To: <9181921C-43BB-48C9-B63D-7C6F99D7A763@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2014 19:27:33 -0000 Hello; On 08/17/14 17:45, Dimitry Andric wrote: > On 17 Aug 2014, at 15:45, Alexey Dokuchaev wrote: >> On Sun, Aug 17, 2014 at 03:29:42PM +0200, Dimitry Andric wrote: >>> In principle it is applicable, but the same file also has other changes >>> in head which were not MFCd, so just MFCing this one commit does not >>> make much sense. For example, the earlier cast fixes were part of a >>> much larger commit by Pedro Giffuni, adding "experimental support for >>> amdfam10/barcelona CPUs": >>> >>> http://svnweb.freebsd.org/base?view=revision&revision=251212 >> I'm running my stable/8 with Pedro's patches applied, including r251212, >> no problems so far (although I don't have recent AMD CPUs to play with). >> >>> Does it still make sense to backport such experimental changes to an old >>> stable branch? Of course I could split off just the changes to >>> emmintrin.h, and leave the others out, but then we would have a partial >>> MFC. I'm not sure if that is the usual way of doing things... >> Understood. My goal here is to try to keep stable/8 as alive as possible, >> since I plan to keep using it beyond its official EOL. Hence, when I see >> fixes that potentially help ports to be buildable on it I'd usually ask if >> they can be MFCed (when it's easy enough to do). FWIW, I recall the AMD patch was developed on stable/8 and should be safe to merge. You still need have to teach the build system about the new CPUs (that was a different change that I didn't do) but it should work. I personally stopped merging stuff to the stable/8 branch and more recently to the stable/9 branch as I don't run those anymore. In the case of the stable/8 branch I find the ancient version of binutils a real threat/limitation. I would really suggest people move on to at least stable/9 which has all the clang cleanups and should be functionally much better. Pedro. > Can you please try this diff [1], which merges most of the stable/9 gcc > changes to stable/8? I've ran it through a make universe, and the only > failure I got was with the amd64 XENHVM kernel: > > amd64 XENHVM kernel failed, check _.amd64.XENHVM for deatils > > but I don't know if this is an expected failure or not. Tinderbox seems > to have other trouble with its stable/8 builds. The actual error is: > > In file included from sys/sys/param.h:86, > from sys/compat/ia32/ia32_genassym.c:6: > sys/sys/types.h:44:28: error: machine/endian.h: No such file or directory > > I didn't test any ports yet, though. > > -Dimitry > > [1] http://www.andric.com/freebsd/sync-stable8-gcc-with-stable9-1.diff.xz >