Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Jan 2012 21:00:31 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-bugs@FreeBSD.org
Subject:   Re: kern/163098: commit references a PR
Message-ID:  <201201152100.q0FL0Vbh037746@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/163098; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/163098: commit references a PR
Date: Sun, 15 Jan 2012 20:52:16 +0000 (UTC)

 Author: eadler (ports committer)
 Date: Sun Jan 15 20:52:01 2012
 New Revision: 230158
 URL: http://svn.freebsd.org/changeset/base/230158
 
 Log:
   MFC r228343:
   	 - Fix ktrace leakage if error is set
   
   PR:		kern/163098
   Approved by:	sbruno
 
 Modified:
   stable/7/sys/kern/kern_ktrace.c
 Directory Properties:
   stable/7/sys/   (props changed)
 
 Modified: stable/7/sys/kern/kern_ktrace.c
 ==============================================================================
 --- stable/7/sys/kern/kern_ktrace.c	Sun Jan 15 20:43:39 2012	(r230157)
 +++ stable/7/sys/kern/kern_ktrace.c	Sun Jan 15 20:52:01 2012	(r230158)
 @@ -462,7 +462,7 @@ ktrsysret(code, error, retval)
  	ktp = &req->ktr_data.ktr_sysret;
  	ktp->ktr_code = code;
  	ktp->ktr_error = error;
 -	ktp->ktr_retval = retval;		/* what about val2 ? */
 +	ktp->ktr_retval = ((error == 0) ? retval: 0);		/* what about val2 ? */
  	ktr_submitrequest(curthread, req);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201152100.q0FL0Vbh037746>