From owner-freebsd-current@FreeBSD.ORG  Tue May  5 14:18:33 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5BA1A106566C
	for <current@freebsd.org>; Tue,  5 May 2009 14:18:33 +0000 (UTC)
	(envelope-from ben@wanderview.com)
Received: from mail.wanderview.com (mail.wanderview.com [66.92.166.102])
	by mx1.freebsd.org (Postfix) with ESMTP id E591D8FC0C
	for <current@freebsd.org>; Tue,  5 May 2009 14:18:32 +0000 (UTC)
	(envelope-from ben@wanderview.com)
Received: from harkness.in.wanderview.com (harkness.in.wanderview.com
	[10.76.10.150]) (authenticated bits=0)
	by mail.wanderview.com (8.14.3/8.14.3) with ESMTP id n45EIUmE034239
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)
	for <current@freebsd.org>; Tue, 5 May 2009 14:18:30 GMT
	(envelope-from ben@wanderview.com)
Message-Id: <9A637B27-7C89-49BA-8385-A5B2D5D54BB3@wanderview.com>
From: Ben Kelly <ben@wanderview.com>
To: current@freebsd.org
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v930.3)
Date: Tue, 5 May 2009 10:18:30 -0400
X-Mailer: Apple Mail (2.930.3)
X-Spam-Score: -1.44 () ALL_TRUSTED
X-Scanned-By: MIMEDefang 2.64 on 10.76.20.1
Cc: 
Subject: [patch] corrupt memstat_kvm_malloc(3) output and dtrace
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 May 2009 14:18:33 -0000

Hi all,

While debugging a problem recently with Alexander Leidinger we noticed  
that crashinfo(8) was producing corrupt vmstat -m output.  After doing  
some digging it appears that memstat_kvm_malloc(3) might have been  
broken by this commit:

   http://svn.freebsd.org/viewvc/base?view=revision&revision=179222

The problem is that memstat_kvm_malloc(3) assumes that  
malloc_type_internal starts with an array of malloc_types_stats  
structures.  This assumption is no longer true, though, as mti_probes  
was inserted at the start of the structure.

It appears that this (untested) patch might fix the problem:

   http://www.wanderview.com/svn/public/misc/zfs/vmstat_kvm_malloc.diff

I'm not very familiar with dtrace, though.  Does anyone know if this  
would cause problems?

Thanks.

- Ben