From owner-svn-src-head@freebsd.org Thu Dec 21 09:50:37 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71A08E8ABFE; Thu, 21 Dec 2017 09:50:37 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E03757FCEE; Thu, 21 Dec 2017 09:50:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id vBL9oRml009075 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 21 Dec 2017 11:50:30 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua vBL9oRml009075 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id vBL9oRl5009074; Thu, 21 Dec 2017 11:50:27 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 21 Dec 2017 11:50:27 +0200 From: Konstantin Belousov To: Marius Strobl , Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327053 - head/sys/sparc64/include Message-ID: <20171221095027.GN12785@kib.kiev.ua> References: <201712210127.vBL1RXFC046423@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201712210127.vBL1RXFC046423@repo.freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 09:50:37 -0000 On Thu, Dec 21, 2017 at 01:27:33AM +0000, Marius Strobl wrote: > Author: marius > Date: Thu Dec 21 01:27:32 2017 > New Revision: 327053 > URL: https://svnweb.freebsd.org/changeset/base/327053 > > Log: > Remove MD atomic_load_{32,64,int,long,ptr}(9) obsolete since the addition > of (conflicting) MI ones in r326971. I am sorry. Initially I wrote the patch with only support for required MI types int long ptr and run the tinderbox. Then I decided that there is no reason to not provide the rest, but did not realized that tb is needed again. > > Modified: > head/sys/sparc64/include/atomic.h > > Modified: head/sys/sparc64/include/atomic.h > ============================================================================== > --- head/sys/sparc64/include/atomic.h Thu Dec 21 01:22:36 2017 (r327052) > +++ head/sys/sparc64/include/atomic.h Thu Dec 21 01:27:32 2017 (r327053) > @@ -258,11 +258,6 @@ atomic_fcmpset_rel_ ## name(volatile ptype p, vtype *e > } \ > \ > static __inline vtype \ > -atomic_load_ ## name(volatile ptype p) \ > -{ \ > - return ((vtype)atomic_cas((p), 0, 0, sz)); \ atomic_cas() does not have any barrier behavior, am I right ? I.e., it does not prevent a reordering in RMO and PSO models. > -} \ > -static __inline vtype \ > atomic_load_acq_ ## name(volatile ptype p) \ > { \ > return ((vtype)atomic_cas_acq((p), 0, 0, sz)); \