Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Jul 2021 00:35:41 GMT
From:      "Bjoern A. Zeeb" <bz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 87c6a74dbe94 - stable/13 - pci: enhance printf for leaked MSI[-X] vectors
Message-ID:  <202107180035.16I0Zfbe048120@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=87c6a74dbe941b2ef0092ac09a734b8a2eceb012

commit 87c6a74dbe941b2ef0092ac09a734b8a2eceb012
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2021-03-23 15:47:24 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2021-07-18 00:34:57 +0000

    pci: enhance printf for leaked MSI[-X] vectors
    
    When debugging leaked MSI/MSI-X vectors through LinuxKPI I found
    the informational printf unhelpful.  Rather than just stating we
    leaked also tell how many MSI or MSI-X vectors we leak.
    
    Sponsored by:   The FreeBSD Foundation
    Reviewed by:    jhb
    Differential Revision:  https://reviews.freebsd.org/D29394
    
    (cherry picked from commit a9f0367b04b385e7bed47914662badf5ab18bc88)
---
 sys/dev/pci/pci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c
index 54d7957dcbf1..ef138e926b6f 100644
--- a/sys/dev/pci/pci.c
+++ b/sys/dev/pci/pci.c
@@ -5044,7 +5044,12 @@ pci_child_detached(device_t dev, device_t child)
 	if (resource_list_release_active(rl, dev, child, SYS_RES_IRQ) != 0)
 		pci_printf(&dinfo->cfg, "Device leaked IRQ resources\n");
 	if (dinfo->cfg.msi.msi_alloc != 0 || dinfo->cfg.msix.msix_alloc != 0) {
-		pci_printf(&dinfo->cfg, "Device leaked MSI vectors\n");
+		if (dinfo->cfg.msi.msi_alloc != 0)
+			pci_printf(&dinfo->cfg, "Device leaked %d MSI "
+			    "vectors\n", dinfo->cfg.msi.msi_alloc);
+		else
+			pci_printf(&dinfo->cfg, "Device leaked %d MSI-X "
+			    "vectors\n", dinfo->cfg.msix.msix_alloc);
 		(void)pci_release_msi(child);
 	}
 	if (resource_list_release_active(rl, dev, child, SYS_RES_MEMORY) != 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107180035.16I0Zfbe048120>