From owner-svn-src-head@FreeBSD.ORG Wed Sep 22 19:58:38 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACBC01065704; Wed, 22 Sep 2010 19:58:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 7F79E8FC0C; Wed, 22 Sep 2010 19:58:38 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 3273546B46; Wed, 22 Sep 2010 15:58:38 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C21658A03C; Wed, 22 Sep 2010 15:58:36 -0400 (EDT) From: John Baldwin To: Gavin Atkinson Date: Wed, 22 Sep 2010 15:58:27 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009211507.o8LF7iVv097676@svn.freebsd.org> <4C9A1602.4020204@freebsd.org> <1285169017.64197.29.camel@buffy.york.ac.uk> In-Reply-To: <1285169017.64197.29.camel@buffy.york.ac.uk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201009221558.27393.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 22 Sep 2010 15:58:36 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andriy Gapon Subject: Re: svn commit: r212964 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Sep 2010 19:58:38 -0000 On Wednesday, September 22, 2010 11:23:37 am Gavin Atkinson wrote: > On Wed, 2010-09-22 at 17:43 +0300, Andriy Gapon wrote: > > on 22/09/2010 16:46 Gavin Atkinson said the following: > > > Ignoring the rest of the discussion about locking, I think this is a > > > step in the right direction. However, what I feel we should be strongly > > > considering is for textdumps to be enabled by default on release media. > > > > > > As more groups choose to use the kernels from the release media (PC-BSD, > > > FreeNAS, etc) and put them into places where end users are never > > > expected to recompile kernels, having textdumps enabled by default in > > > RELEASE kernels becomes a bigger and bigger priority. Groups like > > > PC-BSD don't necessarily have the time or skills to do the needed kernel > > > debugging (and nor should they have to, it's not their purpose), so > > > anything we can do in releases to make sure we have enough info to > > > resolve panics seen by their users is a big bonus. > > > > > > Is there any real reason why we shouldn't go down this route? > > > > textdumps need DDB. > > textdumps also need dumpdev which is not enabled by default in > > /etc/defaults/rc.conf, but that's easier to fix for any individual user or a > > FreeBSD "distribution". > > Indeed, I was happy to see dumpdev enabled on 7.x, and disappointed to > see it disabled on 8.x. Agreed. FWIW, I actually think that this is the only change needed as crashinfo is enabled by default in 8.x and later. We already include symbols in kernels by default now, so just setting dumpdev will give you the same info you generally can get from a textdump in the form of a simple /var/crash/core.txt.N file. The other benefit of full crashdumps + crashinfo as compared to textdumps is that a developer can request further information in a PR followup (fire up kgdb and enter command 'X' and reply with the output). With a textdump any info not collected by the textdump is lost once the machine reboots after the crash. -- John Baldwin