From owner-cvs-all  Wed Jun 23 23:56:46 1999
Delivered-To: cvs-all@freebsd.org
Received: from panzer.plutotech.com (panzer.plutotech.com [206.168.67.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 669DD14A13; Wed, 23 Jun 1999 23:56:41 -0700 (PDT)
	(envelope-from ken@panzer.plutotech.com)
Received: (from ken@localhost)
          by panzer.plutotech.com (8.9.3/8.8.5) id AAA84827;
          Thu, 24 Jun 1999 00:56:41 -0600 (MDT)
From: "Kenneth D. Merry" <ken@plutotech.com>
Message-Id: <199906240656.AAA84827@panzer.plutotech.com>
Subject: Re: cvs commit: src/usr.sbin/i4b/isdnd main.c src/usr.sbin/i4b/isdndebug         main.c src/usr.sbin/i4b/isdndecode main.c src/usr.s
In-Reply-To: <199906240643.XAA20366@freefall.freebsd.org> from Warner Losh at "Jun 23, 1999 11:43:22 pm"
To: imp@FreeBSD.org (Warner Losh)
Date: Thu, 24 Jun 1999 00:56:41 -0600 (MDT)
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Warner Losh wrote...
> imp         1999/06/23 23:43:22 PDT
> 
>   Modified files:
>     usr.sbin/i4b/isdnd   main.c 
>     usr.sbin/i4b/isdndebug main.c 
>     usr.sbin/i4b/isdndecode main.c 
>     usr.sbin/i4b/isdntel main.c 
>     usr.sbin/i4b/isdntelctl main.c 
>     usr.sbin/i4b/isdntest main.c 
>     usr.sbin/i4b/isdntrace trace.c 
>     usr.sbin/iostat      iostat.c 
>     usr.sbin/yppoll      yppoll.c 
>   Log:
>   Two getopts related nits:
>   	o getopt returns -1 rather than EOF on errors
>   	o getopt returns '?' for characters it doesn't know about, so
>   	  don't include them in the getopt options string.
>   
>   1.13      +2 -2      src/usr.sbin/iostat/iostat.c

I'm not sure I agree with this change.

- the iostat(8) man page specifically lists -? as a valid option flag
- taking the -? out of the option string causes getopt to complain:

old version of iostat:

$ iostat -?
usage: iostat [-CdhIKoT?] [-c count] [-M core] [-n devs] [-N system]
              [-t type,if,pass] [-w wait] [drives]

current version of df:

$ df -?
df: illegal option -- ?
usage: df [-ikn] [-t type] [file | filesystem ...]

- I maintain iostat, and you didn't ask me about the change

Ken
-- 
Kenneth Merry
ken@plutotech.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message