From owner-freebsd-stable Thu Jul 12 7:45: 7 2001 Delivered-To: freebsd-stable@freebsd.org Received: from alpo.whistle.com (s206m1.whistle.com [207.76.206.1]) by hub.freebsd.org (Postfix) with ESMTP id 2584037B405 for ; Thu, 12 Jul 2001 07:45:03 -0700 (PDT) (envelope-from mark@whistle.com) Received: from [207.76.207.129] (PBG4.whistle.com [207.76.207.129]) by alpo.whistle.com (8.9.1a/8.9.1) with ESMTP id HAA00975; Thu, 12 Jul 2001 07:43:10 -0700 (PDT) Mime-Version: 1.0 X-Sender: mark-ml@207.76.206.1 Message-Id: In-Reply-To: <20010712082517.E7B7D3E2F@bazooka.unixfreak.org> References: <20010712082517.E7B7D3E2F@bazooka.unixfreak.org> Date: Thu, 12 Jul 2001 07:43:18 -0700 To: Dima Dorfman , Matt Dillon From: Mark Peek Subject: Re: cron exited on signal 11 Cc: stable@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 1:25 AM -0700 7/12/01, Dima Dorfman wrote: >Notice the call to env_free(). That routine does proper piecemeal >cleanup in all cases and for all members of the structure except >`class' (which wasn't there when the original author wrote the >program). It may not have been the right choice, but it's already >been made, and I think remaining consistent with the rest of the file >(or routine) is desirable. Changing free_entry() to support partially >initialized structures may mask bugs. This is the only routine that >initializes the structure and it does it completely; if a field isn't >initialized, that's a bug. > >I guess what I'm saying is that although I wouldn't write it like >that, since it's already written it'd be nice to remain consistent. OK, so that makes 3 of us that would prefer having it rewritten to allow free_entry() to clean up partially initialized structures. Dima, perhaps we should consult with the previous author to review your patches and weigh in to this discussion. Mark To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message