From owner-freebsd-gnome@freebsd.org Mon Mar 30 07:06:22 2020 Return-Path: Delivered-To: freebsd-gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1A2FC27866C for ; Mon, 30 Mar 2020 07:06:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48rNmF1j8Pz4f6m for ; Mon, 30 Mar 2020 07:06:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C29F027863D; Mon, 30 Mar 2020 07:06:13 +0000 (UTC) Delivered-To: gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE50A27863C for ; Mon, 30 Mar 2020 07:06:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48rNm44rTvz4f4K for ; Mon, 30 Mar 2020 07:06:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 07023F649 for ; Mon, 30 Mar 2020 07:00:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 02U70Ljc033317 for ; Mon, 30 Mar 2020 07:00:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 02U70LIu033316 for gnome@FreeBSD.org; Mon, 30 Mar 2020 07:00:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 245156] audio/pulseaudio: parse /dev/sndstat correctly to get device name : [Attachment 212854] Proposed patch (since 516738 revision, v1) Date: Mon, 30 Mar 2020 07:00:21 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2020 07:06:22 -0000 lightside has asked freebsd-gnome mailing list for maintainer-approval: Bug 245156: audio/pulseaudio: parse /dev/sndstat correctly to get device na= me https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245156 Attachment 212854: Proposed patch (since 516738 revision, v1) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D212854&action=3Dedit --- Comment #5 from lightside --- Created attachment 212854 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D212854&action= =3Dedit Proposed patch (since 516738 revision, v1) I created some testcase: -8<-- #include #include int main() { const char *line =3D "pcm4: (play/rec) default"; int device; if (sscanf(line, "pcm%i: ", &device) !=3D 1) return 0; { char *k =3D strchr(line, ':'); k++; k +=3D strspn(k, " <"); char *e =3D strrchr(k, '>'); if (!e) return 0; const size_t len =3D strlen(k) - strlen(e); char m[len]; strncpy(m, k, len); printf("pcm%d: %s\n", device, m); // pcm4: Realtek (0x1168) (Rear Analog 5.1/2.0) } { char *k =3D strrchr(line, '>'); if (!k) return 0; const size_t len =3D strlen(line) - strlen(k) + 1; char m[len]; strncpy(m, line, len); printf("%s\n", m); // pcm4: } return 0; } -->8- which outputs two variants for "pcm4: (play/rec) default" line: -8<-- pcm4: Realtek (0x1168) (Rear Analog 5.1/2.0) pcm4: -->8- Attached patch for first variant.