Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Nov 2019 18:10:42 +0000 (UTC)
From:      Brooks Davis <brooks@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r354688 - head/sys/mips/mips
Message-ID:  <201911131810.xADIAgwB035553@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: brooks
Date: Wed Nov 13 18:10:42 2019
New Revision: 354688
URL: https://svnweb.freebsd.org/changeset/base/354688

Log:
  Fix a typo in the PMAP_PTE_SET_CACHE_BITS macro.
  
  The second argument should have been "pa" not "ps".  It worked by
  accident because the argument was always "pa" which was an in-scope
  local variable.
  
  Submitted by:	sson
  Reviewed by:	jhb, kevans
  Obtained from:	CheriBSD
  MFC after:	3 days
  Sponsored by:	DARPA, AFRL
  Differential Revision:	https://reviews.freebsd.org/D22338

Modified:
  head/sys/mips/mips/pmap.c

Modified: head/sys/mips/mips/pmap.c
==============================================================================
--- head/sys/mips/mips/pmap.c	Wed Nov 13 17:10:46 2019	(r354687)
+++ head/sys/mips/mips/pmap.c	Wed Nov 13 18:10:42 2019	(r354688)
@@ -319,7 +319,7 @@ pmap_pte_cache_bits(vm_paddr_t pa, vm_page_t m)
 		ma = VM_MEMATTR_UNCACHEABLE;
 	return PTE_C(ma);
 }
-#define PMAP_PTE_SET_CACHE_BITS(pte, ps, m) {	\
+#define PMAP_PTE_SET_CACHE_BITS(pte, pa, m) {	\
 	pte &= ~PTE_C_MASK;			\
 	pte |= pmap_pte_cache_bits(pa, m);	\
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911131810.xADIAgwB035553>