From owner-freebsd-audit@FreeBSD.ORG  Tue May 27 07:24:26 2003
Return-Path: <owner-freebsd-audit@FreeBSD.ORG>
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DA6E137B404
	for <audit@FreeBSD.org>; Tue, 27 May 2003 07:24:26 -0700 (PDT)
Received: from gandalf.online.bg (gandalf.online.bg [217.75.128.9])
	by mx1.FreeBSD.org (Postfix) with SMTP id 60A0543FB1
	for <audit@FreeBSD.org>; Tue, 27 May 2003 07:24:22 -0700 (PDT)
	(envelope-from roam@ringlet.net)
Received: (qmail 18854 invoked from network); 27 May 2003 14:17:48 -0000
Received: from office.sbnd.net (HELO straylight.ringlet.net) (217.75.140.130)
  by gandalf.online.bg with SMTP; 27 May 2003 14:17:47 -0000
Received: (qmail 63449 invoked by uid 1000); 27 May 2003 14:21:22 -0000
Date: Tue, 27 May 2003 17:21:22 +0300
From: Peter Pentchev <roam@ringlet.net>
To: Tim Robbins <tjr@FreeBSD.ORG>
Message-ID: <20030527142122.GG513@straylight.oblivion.bg>
Mail-Followup-To: Tim Robbins <tjr@FreeBSD.ORG>, audit@FreeBSD.org
References: <200304220700.h3M70CM3058589@freefall.freebsd.org>
	<20030527084242.GB513@straylight.oblivion.bg>
	<20030527235525.A47880@dilbert.robbins.dropbear.id.au>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="DNUSDXU7R7AVVM8C"
Content-Disposition: inline
In-Reply-To: <20030527235525.A47880@dilbert.robbins.dropbear.id.au>
User-Agent: Mutt/1.5.4i
cc: audit@FreeBSD.org
Subject: Re: conf/51256: chkgrp should make sure the file is newline
	terminated
X-BeenThere: freebsd-audit@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD Security Audit <freebsd-audit.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-audit>
List-Post: <mailto:freebsd-audit@freebsd.org>
List-Help: <mailto:freebsd-audit-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2003 14:24:27 -0000


--DNUSDXU7R7AVVM8C
Content-Type: text/plain; charset=windows-1251
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 27, 2003 at 11:55:25PM +1000, Tim Robbins wrote:
> On Tue, May 27, 2003 at 11:42:42AM +0300, Peter Pentchev wrote:
>=20
> > Could somebody take a look at this PR and the patch (quoted below), and
> > see if there's anything wrong with it or it may be committed?
> [...]
> > >   	if ((line =3D fgetln(gf, &len)) =3D=3D NULL)
> > >   	    break;
> > >  +	if (len > 0 && line[len - 1] !=3D '\n' && line[len - 1] !=3D '\r')=
 {
> > >  +	    warnx("%s: line %d: no newline character", gfn, n);
> > >  +	    e++;
> > >  +	}
> [...]
>=20
> I think that it's unnecessary (and incorrect) to check for a '\r' charact=
er
> at the end of the line.

Okay, this might have been a bad habit of processing files that came
=66rom Over There ;)  So.. how about the patch with only the '\n' check,
then?

G'luck,
Peter

--=20
Peter Pentchev	roam@ringlet.net    roam@sbnd.net    roam@FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
I am not the subject of this sentence.

--DNUSDXU7R7AVVM8C
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)

iD8DBQE+03Ri7Ri2jRYZRVMRAoiLAJkB+7BUw6Z7CwnGMe8sG9vkDWO09gCffvG9
f1U8iEE1tlmjI9Lz8gSSz9o=
=zNIt
-----END PGP SIGNATURE-----

--DNUSDXU7R7AVVM8C--