From nobody Tue Feb 10 15:27:38 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9QRZ2gVbz6RVgr for ; Tue, 10 Feb 2026 15:27:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9QRZ1Rd5z46Wx for ; Tue, 10 Feb 2026 15:27:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ekT8dIBe1+I2ohLllwq0WvGOHUbvZZsSxnZX5ZoFDDQ=; b=NfjxnQ5KyrSLCYMNNmX6CTppNThy/qaP5QbiZHCMmgMmSmKHfuoWDZCGTVV3zG3hULFL3t MC9OX3KCvOxZOWBZNNYb3va8Kiy54/N/Hd/Q3nC3JXIvD3QX+m/SX64wz+jxvE9aAsukil aviHc39ijk5dishkwjRYywU9i9QOOShGEwSbJ0hZBw4G1SAdG0oZJQuc1TW1NEhdinoQRc jDqUzB4GnuITNEf3jR15IxQu2i3k9XHixgKbirXTap6zoxvzNNFo6+YNTFmrW6Belz4ZfE YnhWPRx2kFivEJtDfaxWuEd6ZZHKNg0VvLGReB981OtT/NhbV4RZUEPQuJn5Cw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770737258; a=rsa-sha256; cv=none; b=QNohE5L6J7hrzcXncf7M/TkMffj4T0xe9cKijeV9SDJsr+2bPAb0/Z9f1PhctnBHcptQ/t Kg/8+LL7xGhMGEpQzsbcUJ4ffh5J6M8/kcNqeT9cpKIp8qDNm5PxDL40iHq5myKNef0zq6 88poB29usTldIZ0CYlhF7p0AxBP8gpJ/HEQ6CFyH4vXjAJkUp1Cl40aM4MOYP/wYoKQJ25 E9ElB1CLkvdmsMHk0QbLlkyOnYmVe2597znsdYSRMrwD+5TjVtSYYt6odMzrtMHZVmM8nD puaZH9xCJeNS6Rj0CVCZYk+Ikf8ww/hhENXuQ8XBsD7oW+q7UoBFADnXO63cRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ekT8dIBe1+I2ohLllwq0WvGOHUbvZZsSxnZX5ZoFDDQ=; b=sS+lcG9w6gphIB2ViJMXVr/zAnGqhHkRaygXUoB+QVDGmuqtNdRadxd4xz3YXxrTCXh210 b5egAGx/QVmYG6+wn/l4xUU4ZV81L5AyGJkZjj7/eDoZKmb6nX5OCSnRROMX08zMTrpfUb RkubZNJUQxsog6ps3u6cIbS/u/xy713/5MPfoqYjEY7W5r1g1wT9NQIGyYTzk2YtkCKNhe QXBAXgSgYqa3Fe6/Xr4A8qShpdYYePCu4XdVAvtsKln/8fsJjrxfhnTBwBJgxgGB6tOaKF ZV15K8RGah2bU54VeFr6q1T8tMaJxfPP0ogyzFBVxRfCawR6wRU3BccPoe9wOg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9QRZ0ZGPz1MXW for ; Tue, 10 Feb 2026 15:27:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45bae by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Feb 2026 15:27:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: a0a37c2143e8 - stable/15 - diff: Add test case for pagination resource leak List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: a0a37c2143e82e0df017318d388d12fb2fdf86ea Auto-Submitted: auto-generated Date: Tue, 10 Feb 2026 15:27:38 +0000 Message-Id: <698b4e6a.45bae.312d9a49@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=a0a37c2143e82e0df017318d388d12fb2fdf86ea commit a0a37c2143e82e0df017318d388d12fb2fdf86ea Author: Dag-Erling Smørgrav AuthorDate: 2026-02-05 14:39:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-10 14:24:08 +0000 diff: Add test case for pagination resource leak The pagination code leaks either processes or descriptors or both, depending on the exact version of the code you have. Add a test case which exercises this leak to facilitate fixing it. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: thj, kevans Differential Revision: https://reviews.freebsd.org/D55111 (cherry picked from commit 270492602b9bd8b8fce4f021f055804978bf3f23) --- usr.bin/diff/tests/diff_test.sh | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/usr.bin/diff/tests/diff_test.sh b/usr.bin/diff/tests/diff_test.sh index 89348d3a8b16..a3f76602cf37 100755 --- a/usr.bin/diff/tests/diff_test.sh +++ b/usr.bin/diff/tests/diff_test.sh @@ -411,6 +411,27 @@ bigu_body() diff -Astone -U$(((1<<31)-2)) a b } +prleak_head() +{ + atf_set "descr" "Verify that pagination does not leak resources" +} +prleak_body() +{ + local n=32 + mkdir a b + for hi in $(jot -w%02x $n 0) ; do + mkdir a/$hi b/$hi + for lo in $(jot -w%02x $n 0) ; do + echo "$hi$lo" >a/$hi/$lo + echo "$hi$lo" >b/$hi/$lo + done + done + ulimit -n 1000 + ulimit -u 1000 + atf_check diff -rul a b + atf_check diff -Astone -rul a b +} + atf_init_test_cases() { atf_add_test_case simple @@ -440,4 +461,5 @@ atf_init_test_cases() atf_add_test_case dirloop atf_add_test_case bigc atf_add_test_case bigu + atf_add_test_case prleak }