From owner-svn-src-all@FreeBSD.ORG Mon Dec 16 21:48:39 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0515ED01; Mon, 16 Dec 2013 21:48:39 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B952810EC; Mon, 16 Dec 2013 21:48:38 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.17]) by ltcfislmsgpa05.fnfis.com (8.14.5/8.14.5) with ESMTP id rBGLmbsI012464 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Mon, 16 Dec 2013 15:48:37 -0600 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.7]) by LTCFISWMSGHT06.FNFIS.com ([10.132.206.17]) with mapi id 14.03.0158.001; Mon, 16 Dec 2013 15:48:36 -0600 From: "Teske, Devin" To: Nathan Whitehorn Subject: Re: svn commit: r259479 - head/usr.sbin/bsdinstall/scripts Thread-Topic: svn commit: r259479 - head/usr.sbin/bsdinstall/scripts Thread-Index: AQHO+qdwM2JIT2GF3kyccjUlXq6l7JpXwGqA Date: Mon, 16 Dec 2013 21:48:35 +0000 Message-ID: References: <201312161947.rBGJl4Jh087762@svn.freebsd.org> <52AF6FF6.1030909@freebsd.org> <7BF56E5D-CDE7-4E57-BA47-3565CD07236C@fisglobal.com> In-Reply-To: <7BF56E5D-CDE7-4E57-BA47-3565CD07236C@fisglobal.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.120] Content-Type: text/plain; charset="us-ascii" Content-ID: <4360776B995F63419A3A9F54A2429B37@fisglobal.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.87, 1.0.14, 0.0.0000 definitions=2013-12-16_01:2013-12-16,2013-12-16,1970-01-01 signatures=0 Cc: "svn-src-head@freebsd.org" , Devin Teske , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "Teske, Devin" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Devin Teske List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2013 21:48:39 -0000 On Dec 16, 2013, at 1:40 PM, Teske, Devin wrote: >=20 > On Dec 16, 2013, at 1:26 PM, Nathan Whitehorn wrote: >=20 >> On 12/16/13 13:47, Devin Teske wrote: >>> Author: dteske >>> Date: Mon Dec 16 19:47:04 2013 >>> New Revision: 259479 >>> URL: https://urldefense.proofpoint.com/v1/url?u=3Dhttp://svnweb.freebsd= .org/changeset/base/259479&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs= 6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=3DfW6SVzmwwyz0yNXNK7sHp4zegrL63niU%2F%2F2= 1DVtgyGU%3D%0A&s=3Dcdd7f18e0151f222c2934ae69e473dac2e22e74cbde4d5af5758a083= fb1c3a7e >>>=20 >>> Log: >>> Add kern.geom.label.disk_ident.enable=3D"0" to loader.conf(5). >>> Discussed on: -current, -stable >>> MFC after: 3 days >>>=20 >>> Modified: >>> head/usr.sbin/bsdinstall/scripts/zfsboot >>>=20 >>> Modified: head/usr.sbin/bsdinstall/scripts/zfsboot >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/usr.sbin/bsdinstall/scripts/zfsboot Mon Dec 16 19:44:45 2013 (= r259478) >>> +++ head/usr.sbin/bsdinstall/scripts/zfsboot Mon Dec 16 19:47:04 2013 (= r259479) >>> @@ -1159,6 +1159,9 @@ zfs_create_boot() >>> $BSDINSTALL_TMPETC/rc.conf.zfs || return $FAILURE >>> f_eval_catch $funcname echo "$ECHO_APPEND" 'zfs_load=3D\"YES\"' \ >>> $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE >>> + f_eval_catch $funcname echo "$ECHO_APPEND" \ >>> + 'kern.geom.label.disk_ident.enable=3D\"0\"' \ >>> + $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE >>> # We're all done unless we should go on for boot pool >>> [ "$ZFSBOOT_BOOT_POOL" ] || return $SUCCESS >>=20 >> Uh -- what is all of this? Why are we disabling kernel functions dependi= ng on what the root filesystem is? Please don't MFC this. >=20 > http://lists.freebsd.org/pipermail/freebsd-stable/2013-December/076365.ht= ml > http://lists.freebsd.org/pipermail/freebsd-stable/2013-December/076471.ht= ml >=20 > NB: Happy to rip it out... but want something in-reply to those threads (= pretty please). Basically... the logic is... The ZFS pool is built on vdevs of a specific name. The names that are used should remain the same. Adding this to the loader.conf ensures that the nam= es that the pool(s) was/were built upon do not change. This goes beyond just a swap partition I imagine. For example... copying the data to a new drive using a duplicator. I'm sure there are other cases too. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.