From owner-freebsd-hackers@freebsd.org Thu May 19 05:19:06 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC040B410CF for ; Thu, 19 May 2016 05:19:06 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B8B7B1469 for ; Thu, 19 May 2016 05:19:06 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mail-io0-x22c.google.com with SMTP id i75so93461918ioa.3 for ; Wed, 18 May 2016 22:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=YcL62T6oZFvzoDEsV00kzD1FSiUdzwlBwq2iTRKaLwk=; b=HE2VWNNfNwohwN+z65cff6A3qw2iNl0pD4amzBGNJXce+s4bK3UlcB3OfY8n2B3Vt8 GjglFhCyWSJiGstZ1QhBTaxbxc9hMoILokwCRFFBP39XU2pZK+t+EEfcl0XpueSQdx9N qpm9dlnhLg65nCqUxPwP7FxeGz4lf+4Y16pICPYUmdgPVGHbQpeqJonqg5N041nkZ15h dT4d22ZvJTHHwyfFNEPaMF9nbz/DPWIsZkfjOYOE91fgNOU7Vwzf/ITzk8G8i4GJqP/Q j6j7wuo2zJNHqsW1YlV3itzDN3egTuYnc83mpSmk6oXGWZWwotwoyGh2E6379TtFC9p1 ajRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=YcL62T6oZFvzoDEsV00kzD1FSiUdzwlBwq2iTRKaLwk=; b=Ccv51uPVKQTeVM9ah3ZWIBlAmZE3ao3DAD8JtjI3YvG/UeA+HOo53dRkcj0Un1rLsM sYMEGmrnvebJcpll4AGw0l5qklNyHI8exGxeH6cNNB2NeBCk6T+/3l7ESvuoseme7vqi IIm1Wz22/Yyl3lmPyPMYm1foJhgKLbhkQQYQxO+NTjFN7z/7BDz19pXK5NMEa4btnrPG zCu7UOa0cz0dEygDuQHP2XNOrFMB/isq0Lqr/uV2lH/x7RQfQjgGeR9MS1gQD0zppsNC z7dvbogzWFGjL9Y42WfE0Gd9zZPG/MiPhFktLiEjKirOpdBUCweK0QWz9LQLkabpWrb/ tJuw== X-Gm-Message-State: AOPr4FUQHvKmwymg0+x9in5fbLqpc7z36SHOGpKto8MtjI7052k5sxZIuaQvsgM2GkKqUocS2VqRHMDEe0B4tA== MIME-Version: 1.0 X-Received: by 10.36.208.84 with SMTP id m81mr1325711itg.56.1463635146159; Wed, 18 May 2016 22:19:06 -0700 (PDT) Sender: kmacybsd@gmail.com Received: by 10.107.140.8 with HTTP; Wed, 18 May 2016 22:19:06 -0700 (PDT) In-Reply-To: <20160519041118.GE19887@gmail.com> References: <20160519041118.GE19887@gmail.com> Date: Wed, 18 May 2016 22:19:06 -0700 X-Google-Sender-Auth: 2jZSGV4QErMRiOtfeiKDSLEDe5g Message-ID: Subject: Re: What changes are welcome? From: "K. Macy" To: Randy Westlund Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 05:19:07 -0000 On Wed, May 18, 2016 at 9:11 PM, Randy Westlund wrote: > I'd like to start contributing to the base system, but I need > clarification on what sort of changes would be welcome. > > I thought I'd start on simple compiler warnings. The top code in > /contrib/top, for example uses K&R-style function definitions and > implicit return types that spews -Wimplicit-int and -Wreturn-type > warnings. > > While I'm silencing those, is it appropriate for me to make the file > follow style(9)? > > Once I have a diff, should I just upload it to bugzilla, or is it > preferable to put it on phabricator and then link to it from bugzilla? Phabricator is the place to put any patches you want reviewed. Just as important to understand as the technical is the social aspect. FreeBSD does not have a 6c equivalent to the Linux Foundation or large companies like Redhat where individuals are paid full-time to facilitate the import of contributions. You need to go out of your way to cultivate a rapport with one or more committers so that one of them will take time out of his day to commit your changes and potentially cope with any fallout. I contributed some changes a day or two ago and I broke the kernel build in a couple of arches :(. You're going to find that without such a rapport in place your patches are likely to be ignored or, if they're substantial, worse yet actually argued against. And if at first you're ignored, don't take it personally. FreeBSD is a collection of individuals, each with his or her own hot buttons and interests. -M