From owner-svn-src-head@freebsd.org Tue Oct 22 16:35:18 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3280615F212; Tue, 22 Oct 2019 16:35:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46yJyZ0Hyzz413N; Tue, 22 Oct 2019 16:35:17 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x442.google.com with SMTP id h195so10975379pfe.5; Tue, 22 Oct 2019 09:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=LBWVaAZnUfWZzW7If0qTeYULMKgLM6bPt4biAqhQ4WM=; b=p2tStdaui1irzhRezQ/maPMiHxa58jd5d3qpV1ipYWKpwWW59+zwfii72OYy/BXKKC 0EBvr/6NRBgwBemw9dnX91AWSkKLDeqNuBxzLZejPz19txT8bvH/GXIkzUvedRvngrrC eFDmjUILDIJy5Ql/mAd5apPQVHLOrIZjJtnViUSkQ62M7iml6lIjBzV08x0fsx/jAkSV IG8+t0Vjqcx8IrNj+ffA09608DPV3lpCuWe21WE5cNp36uzsP2RmI08JVh6Icua53GJK pmKbTimsgA4GO3dRBEwNdJPpQAtbzUudAUdfwzXlb7YhGpibQ6kP5H3lYEXn4JrU8wbr tCbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=LBWVaAZnUfWZzW7If0qTeYULMKgLM6bPt4biAqhQ4WM=; b=ck1pGlAykaGFkL/3yUBfjb3F0zPT8sGPQ2wwP/OrC44wZzH6siwoj2WBf1kX0MAdUb MR6iwezUpKA5irBpNC2K1gRVJsGJexQDXR/XiX2pfFhCOEsDogLwBGvMaxktDPemsQNw XyZsy8w5kcGq493hUKibodSnSxZao7qnbNJTcGm+NfclqdRNEehzmLrfqnrBgaFlfn26 Xal9aDLdeIQyxXepyDtk675jVDYzX9EkyMXeh4qmI1DXdRzp6M/eeelr8OZOhl5f97Yw CXXA54Yx88ipQdPIipuiFO6TRuOdFep4BJDJi14Og9vz1lFBMONdks9+tj0H6xnebhcS +Trw== X-Gm-Message-State: APjAAAWpScICFCJOobmc5ugW6BE2lRav+S56Iy9R0foLpKQQjuqNaGZk 3aDmOQWc1zx2g34Jrd/UzK53YJ0d X-Google-Smtp-Source: APXvYqyatgwap5YkPwYxKjh0xRFR77/V8+OrRwuBgvtPiUN2bn/p4AtgtCFO4jY9jjUlNib6DpfJGA== X-Received: by 2002:a63:b5b:: with SMTP id a27mr4945273pgl.262.1571762116419; Tue, 22 Oct 2019 09:35:16 -0700 (PDT) Received: from ?IPv6:2607:fb90:8364:7608:20b8:9b0:3e3e:87bc? ([2607:fb90:8364:7608:20b8:9b0:3e3e:87bc]) by smtp.gmail.com with ESMTPSA id p17sm18674270pfn.50.2019.10.22.09.35.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 09:35:15 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Enji Cooper Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r353732 - head/sys/net Date: Tue, 22 Oct 2019 09:35:14 -0700 Message-Id: References: <20191022152646.GI4086@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <20191022152646.GI4086@FreeBSD.org> To: Gleb Smirnoff X-Mailer: iPhone Mail (17A878) X-Rspamd-Queue-Id: 46yJyZ0Hyzz413N X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 16:35:18 -0000 > On Oct 22, 2019, at 08:26, Gleb Smirnoff wrote: >=20 > =EF=BB=BFOn Tue, Oct 22, 2019 at 07:53:31AM -0700, Enji Cooper wrote: > E> > =EF=BB=BFAuthor: glebius > E> > Date: Fri Oct 18 15:20:24 2019 > E> > New Revision: 353732 > E> > URL: https://svnweb.freebsd.org/changeset/base/353732 > E> >=20 > E> > Log: > E> > Make rt_getifa_fib() static. > E>=20 > E> Why should it be made static? The answer to this question is missing fr= om the commit message. >=20 > Because a function used only in a scope of a single file and not > intended to be used outside should be made static. Gleb, Yep :)! I appreciate your doing this because it limits scopes and calls, all= owing compilers to optimize away unnecessary calls and external symbol linka= ge. My concern is coming back to the time old issue of providing sufficient cont= ext behind commits when making changes. Looking at the code change you made,= I understand what you did... I just lack the context as to why the changes w= as made. This issue is true for the recent KPI rototilling related to interface prope= rty enumeration. If I hadn=E2=80=99t seen your mailing list RFC, I would lac= k all context as to why the changes are being made. Even a quick reference t= o a one page write up on the wiki, a proposal, or release notes would be won= derful moves towards documenting why interface changes are being made. I want to thank you so very much for all of the awesome work you have done a= nd are continuing to do in the network space =E2=80=94 I really appreciate i= t a lot! Again, I just wish the reasoning behind the work was made more appa= rent to onlookers as to why changes are being made. Cheers :)! -Enji=