From owner-p4-projects@FreeBSD.ORG Mon Nov 17 01:42:02 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C9D2A1065674; Mon, 17 Nov 2008 01:42:02 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F1691065670; Mon, 17 Nov 2008 01:42:02 +0000 (UTC) (envelope-from haro@kgt.co.jp) Received: from mail02.kgt.co.jp (dmz02.kgt.co.jp [210.141.246.82]) by mx1.freebsd.org (Postfix) with ESMTP id 5F8E78FC16; Mon, 17 Nov 2008 01:42:02 +0000 (UTC) (envelope-from haro@kgt.co.jp) Received: from navgw.tt.kgt.co.jp (unknown [210.141.246.71]) by mail02.kgt.co.jp (Postfix) with ESMTP id 2B61A3C43F8E; Mon, 17 Nov 2008 10:30:39 +0900 (JST) Received: from localhost (posh.tt.kgt.co.jp [192.168.15.51]) by navgw.tt.kgt.co.jp (Postfix) with ESMTP id E85E047712; Mon, 17 Nov 2008 10:30:38 +0900 (JST) Date: Mon, 17 Nov 2008 10:30:38 +0900 (JST) Message-Id: <20081117.103038.36764854.haro@kgt.co.jp> To: nwhitehorn@FreeBSD.org From: haro@kgt.co.jp In-Reply-To: <200811162259.mAGMxvlw026231@repoman.freebsd.org> References: <200811162259.mAGMxvlw026231@repoman.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: perforce@freebsd.org Subject: Re: PERFORCE change 153060 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2008 01:42:03 -0000 From: Nathan Whitehorn Date: Sun, 16 Nov 2008 22:59:57 GMT ::http://perforce.freebsd.org/chv.cgi?CH=153060 :: ::Change 153060 by nwhitehorn@nwhitehorn_trantor on 2008/11/16 22:59:28 :: :: Fix interrupt-cells detection on Grackle. :: ::Affected files ... :: ::.. //depot/projects/ppc-g5/sys/powerpc/powermac/grackle.c#7 edit :: ::Differences ... :: ::==== //depot/projects/ppc-g5/sys/powerpc/powermac/grackle.c#7 (text+ko) ==== :: ::@@ -255,10 +255,12 @@ :: ofw_bus_setup_iinfo(node, &sc->sc_pci_iinfo, sizeof(cell_t)); :: :: /* We need the number of interrupt cells to read the imap */ ::- sc->sc_icells = 2; ::- if (OF_getprop(node, "interrupt-parent", &iparent,sizeof(iparent)) > 0) ::- OF_getprop(iparent,"#interrupt-cells",&sc->sc_icells, ::- sizeof(sc->sc_icells)); ::+ if (OF_getprop(node, "interrupt-parent", &iparent,sizeof(iparent)) <= 0) ::+ iparent = node; ::+ ::+ if (OF_getprop(iparent,"#interrupt-cells",&sc->sc_icells, ::+ sizeof(sc->sc_icells)) <= 0); ::+ sc->sc_icells = 1; Hello Nathan, A ";" after "if" statement does not seem correct to me. Hope this helps, Haro =----------------------------------------------------------------------- _ _ Munehiro (haro) Matsuda -|- /_\ |_|_| KGT Inc. /|\ |_| |_|_|