Date: Sun, 04 Jun 2006 15:15:44 -0400 From: Paul Murphy <paul.murphy@cogeco.ca> To: =?ISO-8859-1?Q?K=F6vesd=E1n_G=E1bor?= <gabor.kovesdan@t-hosting.hu> Cc: freebsd-ports@freebsd.org Subject: Re: security/amavisd-new startup script Message-ID: <44833160.8040709@cogeco.ca> In-Reply-To: <44830D96.3060809@t-hosting.hu> References: <447F68B4.7050503@cogeco.ca> <44830D96.3060809@t-hosting.hu>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------090309030200050503040801
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
K=F6vesd=E1n G=E1bor wrote:
> Paul Murphy wrote:
>> I need to keep the amavisd-new pid file in a location other than the=20
>> default (/var/amavis/amavisd.pid), so I have rewritten the amavis rc=20
>> script to include a knob for 'pidfile'. Please consider the attached=20
>> file for the amavisd-new port.
>> ----------------------------------------------------------------------=
--
>>
>> #!/bin/sh
>> #
>> # $FreeBSD: ports/security/amavisd-new/files/amavisd.sh.in,v 1.3=20
>> 2006/02/20 20:47:36 dougb Exp $
>> #
>>
>> # PROVIDE: amavisd
>> # REQUIRE: LOGIN
>> # BEFORE: mail
>> # KEYWORD: shutdown
>>
>> #
>> # Add the following lines to /etc/rc.conf to enable amavisd:
>> #
>> #amavisd_enable=3D"YES"
>> #
>>
>> . /etc/rc.subr
>>
>> name=3Damavisd
>> rcvar=3D`set_rcvar`
>>
>> load_rc_config $name
>>
>> # Set defaults
>> : ${amavisd_enable:=3D"NO"}
>>
>> pidfile=3D${amavisd_pid:-"/var/amavis/amavisd.pid"}
>> command=3D/usr/local/sbin/amavisd > /dev/null 2>&1
>> required_files=3D/usr/local/etc/amavisd.conf
>>
>> stop_postcmd=3Dstop_postcmd
>>
>> stop_postcmd()
>> {
>> rm -f $pidfile
>> }
>>
>> run_rc_command "$1"
>> =20
> I'd found this "new feature" a good idea first, but now, after a deeper=
=20
> look, I realized that we can't set the pid file with a command-line=20
> option, just in the config file. Thus, if we wanted to use an alternate=
=20
> location for a pid file, we would have to change it in two places: in=20
> amavisd.conf and in rc.conf. Accordingly, I think such modification in=20
> the rc script might deceive people, so I'd prefer keeping it as is.=20
> Anyway, I don't think that location does have to be changed in the=20
> average case, it might be a special requirement of you. Opinions from=20
> others are appreciated!
>=20
Yes, I thought about that too. I wonder if
command_args=3D"-p ${pidfile} > /dev/null 2>&1"
would work?
However I realize that my request is a special case and I should look=20
after it myself.
Thanks for looking into it though (and thanks to Doug Barton for some=20
hints).
Attached is my final result, for anyone else who is interested.
--------------090309030200050503040801
Content-Type: text/plain;
name="amavisd"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="amavisd"
#!/bin/sh
#
# PROVIDE: amavisd
# REQUIRE: LOGIN
# BEFORE: mail
# KEYWORD: shutdown
#
# Add the following lines to /etc/rc.conf to enable amavisd:
#
#amavisd_enable="YES"
#
. /etc/rc.subr
name=amavisd
rcvar=${name}_enable
command=/usr/local/sbin/amavisd
required_files=/usr/local/etc/amavisd.conf
load_rc_config $name
# Set defaults
: ${amavisd_enable="NO"}
pidfile=${amavisd_pid-"/var/amavis/amavisd.pid"}
command_args="> -p ${pidfile} /dev/null 2>&1"
stop_postcmd=${name}_poststop
amavisd_poststop()
{
rm -f $pidfile
}
run_rc_command "$1"
--------------090309030200050503040801
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Content-Description: avast info
---
avast! Antivirus: Outbound message clean.
Virus Database (VPS): 0622-4, 02/06/2006
Tested on: 04/06/2006 3:15:46 PM
avast! - copyright (c) 1988-2006 ALWIL Software.
http://www.avast.com
--------------090309030200050503040801--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44833160.8040709>