From owner-cvs-src@FreeBSD.ORG Fri Oct 26 12:53:47 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1693216A420 for ; Fri, 26 Oct 2007 12:53:47 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.178]) by mx1.freebsd.org (Postfix) with ESMTP id D212913C48E for ; Fri, 26 Oct 2007 12:53:46 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so1040066waf for ; Fri, 26 Oct 2007 05:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=VoKrsnftI1Vlls5Aa9N6mxkNBrpL5gossFUZsp1Qj34=; b=CHaK0ux1LW2QNfST4iDiNSLS+fC/A6e6vuRaQ3MBRhEG3hDqERYZRDep5l1YKMppbJnTkDAdVU49K/AFOdILdUgrVn/fcg1NTZvr+qyjl0Inc74SKJvzrTzwixQ62OwyP91uVa1mwhInH9CJQv2/MOpx1QzBidzhUyKSnP2Q040= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=hr1QudDygjzBPFqLp0qPWehgUo0Rmcf3fHWXMiRmgP8tAoxGzlv5baF4tCDRedKHIh4sbSdfxFUTwGC1Ffrfn4/EvCOCh//q7oAhDd/LajlytM3c1NebzgIO/kBga7KlN1HxQlxXoGeecXvdaqG+FFCvZjzupDYCkyzTPYuwkOc= Received: by 10.115.110.6 with SMTP id n6mr3416314wam.1193403226418; Fri, 26 Oct 2007 05:53:46 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id n32sm6354030wag.2007.10.26.05.53.42 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Oct 2007 05:53:44 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l9QCrZLg023194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Oct 2007 21:53:35 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l9QCrZ6w023193; Fri, 26 Oct 2007 21:53:35 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Fri, 26 Oct 2007 21:53:35 +0900 From: Pyun YongHyeon To: JoaoBR Message-ID: <20071026125335.GF20617@cdnetworks.co.kr> References: <200710120341.l9C3fsWe058991@repoman.freebsd.org> <200710261011.42367.joao@matik.com.br> <20071026121832.GE20617@cdnetworks.co.kr> <200710261035.45408.joao@matik.com.br> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710261035.45408.joao@matik.com.br> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2007 12:53:47 -0000 On Fri, Oct 26, 2007 at 10:35:44AM -0200, JoaoBR wrote: > On Friday 26 October 2007 10:18:32 Pyun YongHyeon wrote: > > > > > > Hi > > > > > since I upgraded to 7 this days I loss connection to a machine with > > > > > vr nic > > > > > > > > > > the only event I can find after resetting (i have no phisical > > > > > access) is > > > > > > > > > > Oct 26 04:31:56 ap-c kernel: vr0: link state changed to DOWN > > > > > > > > > > may it be related? What should I do? > > > > > > > > I'm pretty sure it's not related with my changes. > > > > > > > > If you think vr(4) is culprit for the issue try overhauled vr(4). > > > > I think I've fixed many unresolved vr(4) issues but it needs more > > > > testing. > > > > You can download the overhauled vr(4) at the following URL. > > > > http://people.freebsd.org/~yongari/vr/if_vr.c > > > > http://people.freebsd.org/~yongari/vr/if_vrreg.h > > > > > > > > Note, don't use the overhauled driver on your production system. > > > > I couldn't see any issues in the driver but it may have unnoticed > > > > bugs. > > > > > > I will arrange a test machine to see how it goes > > > > Ok. Let me know if you see any unusual things. Pluging/unpluging > > cables shouldn't affect the operation of vr(4). I heard stock vr(4) > > is vulerable to this type of link changes. In addition, you may > > notice better Rx performance. > > > > oh no, it is not that, I wanted to say when the down event already has taken > place then we can re-activate the vr nic (to up) by unplugging the network > cable on the switch and access the machine again > There are two issues here. 1st, there should be no abnormal device down and you shouldn't need to unplug/replug the cable to access the machine. vr(4) should detect valid link automatically and reinitialize it. 2nd, repeating cable plug/unplug action should not cause panic anymore. > Also this machine is running almost a year perfectly releng_6 and current for > over a month or so until the latest update 2 days ago > Probably not. I guess you missed one thing. phk changed a lot of code to support checksum offload and rearranged the code a bit not to align Tx buffers for Rhine II/III. These changes were not MFCed to RELENG_6. > btw, both files are almost twice in size, is it correct? > > 66987 26 Out 10:27 if_vr.c > 39430 12 Out 00:41 if_vr.c.ori > 20062 26 Out 10:27 if_vrreg.h > 15445 23 Abr 2007 if_vrreg.h.ori > > v 1.126 2007/04/23 12:19:02 phk > v 1.34 2007/04/23 12:19:02 phk > As I said in previous mail, it's major overhauled driver. It contains all bus_dma(9) changes to run it on other architectures such as sparc64 and added new hardware feature support code.(VLAN hardware tag insertion/extraction, CAM filtering support etc.) -- Regards, Pyun YongHyeon