From owner-cvs-all Wed Dec 20 7:16:33 2000 From owner-cvs-all@FreeBSD.ORG Wed Dec 20 07:16:29 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from rucus.ru.ac.za (rucus.ru.ac.za [146.231.29.2]) by hub.freebsd.org (Postfix) with SMTP id 27BBA37B699 for ; Wed, 20 Dec 2000 07:16:24 -0800 (PST) Received: (qmail 54601 invoked by uid 1003); 20 Dec 2000 15:16:17 -0000 Date: Wed, 20 Dec 2000 17:16:17 +0200 From: Neil Blakey-Milner To: Warner Losh , Assar Westerlund , Dag-Erling Smorgrav , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, marcel@FreeBSD.org Subject: Re: cvs commit: src/sys/libkern strlcat.c strlcpy.c src/sys/sys libkern.h src/sys/conf files Message-ID: <20001220171617.A49980@mithrandr.moria.org> References: <5l66khluty.fsf@assaris.sics.se> <5lsnnlkcf7.fsf@assaris.sics.se> <5l4s01ka92.fsf@assaris.sics.se> <200012181724.KAA91757@harmony.village.org> <20001219081616.D54775@gsmx07.alcatel.com.au> <20001220142934.I644@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001220142934.I644@ringworld.oblivion.bg>; from roam@orbitel.bg on Wed, Dec 20, 2000 at 02:29:34PM +0200 X-Operating-System: FreeBSD 4.1-STABLE i386 X-URL: http://mithrandr.moria.org/nbm/ Sender: nbm@rucus.ru.ac.za Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed 2000-12-20 (14:29), Peter Pentchev wrote: > On Tue, Dec 19, 2000 at 08:16:16AM +1100, Peter Jeremy wrote: > > On 2000-Dec-18 10:24:28 -0700, Warner Losh wrote: > > > The one in libc is known to > > >be good and not have any bugs, so why reinvent it for the kernel? > > > > I'd go further and say that unless there is a compelling reason > > otherwise, libkern should always use the code in libc (or vice versa). > > It's a pity that our source structure doesn't allow us to use the > > same file (you can checkout and build the kernel without installing > ^^^^^^^^^^^^^^^^ > > the userland sources). > > Hmm.. quite off-topic, but - is this so on -current? (I'll be able to > test this in a matter of hours, refetching my -current source tree) > It most definitely is NOT correct for 4-stable - the kernel build > requires 'nm' (IIRC) from /usr/obj; if not 'nm', then something else > from the build toolchain. A few months ago, I sent Marcel what I believe to be the "equivalently broken" behaviour for setting OBJFORMAT_PATH to look for nm (and other objformat-using utilities) on the installed filesystem if they're not there. It's "equivalently broken" because we allow the use of gcc, ld, and friends off the installed filesystem if they're not in the obj tree by virtue of having a PATH that allows this. Also, I do not believe it helps anyone to not be able to build the kernel if they don't have a obj tree. However, I've left it to him, since he's the one mostly doing these things, and he said he'd like to think over it in case it breaks something non-obvious. I suppose this is a nudge to look at it again - we really need to fix this. Neil -- Neil Blakey-Milner nbm@mithrandr.moria.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message