From owner-freebsd-current Mon May 25 03:25:22 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id DAA17823 for freebsd-current-outgoing; Mon, 25 May 1998 03:25:22 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA17810 for ; Mon, 25 May 1998 03:25:19 -0700 (PDT) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id KAA06906; Mon, 25 May 1998 10:25:17 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id MAA02074; Mon, 25 May 1998 12:25:07 +0200 (MET DST) Message-ID: <19980525122507.46281@follo.net> Date: Mon, 25 May 1998 12:25:07 +0200 From: Eivind Eklund To: Michael Hancock , Terry Lambert Cc: freebsd-current@FreeBSD.ORG Subject: Re: May 17th UP machine 'panic' References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: ; from Michael Hancock on Mon, May 25, 1998 at 06:59:01AM +0900 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, May 25, 1998 at 06:59:01AM +0900, Michael Hancock wrote: > Tor might have identified the problem. vput() doesn't take a process > argument and always uses curproc. I suggested splitting up the offending > vput() into vrele() and VOP_UNLOCK(). > > So I guess you are right, vput() is assymetric in that it doesn't take a > proc arg, but this would be too much work to fix. How? If it is usually only interested in curproc, doing a search/replace shouldn't be too hard. It is used "only" about 300 places ;-) (There are about five calls to vput that is used on another call, to create trouble for a straight regexp replace. Not so much it would make it hard to handle.) I don't know which effect such a change would have on performance - that's for you expert to answer :-) Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message