Date: Wed, 5 Jun 2002 22:18:54 +0300 (EEST) From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/38929: WARNS=3 fixes for src/usr.bin/makewhatis Message-ID: <200206051918.g55JIsuF013719@hades.hell.gr>
next in thread | raw e-mail | index | archive | help
>Number: 38929
>Category: bin
>Synopsis: WARNS=3 fixes for src/usr.bin/makewhatis
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 05 14:50:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Giorgos Keramidas
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD hades.hell.gr 5.0-CURRENT FreeBSD 5.0-CURRENT #0:
Wed Jun 5 05:24:39 EEST 2002
root@hades.hell.gr:/usr/obj/usr/src/sys/HECATE i386
>Description:
The attached patch corrects the few warnings that makewhatis.c
causes when compiled with WARNS=3.
>How-To-Repeat:
% cd src/usr.bin/makewhatis/
% make WARNS=3 clean all
>Fix:
--- foo begins here ---
Index: makewhatis.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/makewhatis/makewhatis.c,v
retrieving revision 1.5
diff -u -r1.5 makewhatis.c
--- makewhatis.c 22 May 2002 11:08:41 -0000 1.5
+++ makewhatis.c 5 Jun 2002 19:16:18 -0000
@@ -293,7 +293,7 @@
no_page_exists(char *dir, StringList *names, char *suffix)
{
char path[MAXPATHLEN];
- int i;
+ unsigned int i;
for (i = 0; i < names->sl_cur; i++) {
snprintf(path, sizeof path, "%s/%s.%s.gz", dir, names->sl_str[i], suffix);
@@ -363,7 +363,7 @@
static void
finish_output(FILE *output, char *name)
{
- int i;
+ unsigned int i;
char *prev = NULL;
qsort(whatis_lines->sl_str, whatis_lines->sl_cur, sizeof(char *), linesort);
@@ -693,7 +693,7 @@
StringList *names;
char *descr;
int state = STATE_UNKNOWN;
- int i;
+ unsigned int i;
sbuf_clear(whatis_proto);
if ((in = gzopen(page->filename, "r")) == NULL) {
@@ -824,7 +824,7 @@
struct page_info **pages;
int npages = 0;
int i;
- int prev_inode = 0;
+ unsigned int prev_inode = 0;
if (verbose)
fprintf(stderr, " %s\n", section_dir);
--- foo ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206051918.g55JIsuF013719>