From owner-freebsd-current Wed Oct 30 5:31:19 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A197E37B404 for ; Wed, 30 Oct 2002 05:31:17 -0800 (PST) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D87943E3B for ; Wed, 30 Oct 2002 05:31:17 -0800 (PST) (envelope-from eischen@pcnet1.pcnet.com) Received: from localhost (eischen@localhost) by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id g9UDVG9c017614; Wed, 30 Oct 2002 08:31:16 -0500 (EST) Date: Wed, 30 Oct 2002 08:31:16 -0500 (EST) From: Daniel Eischen To: Terry Lambert Cc: Doug Rabson , current@FreeBSD.ORG Subject: Re: [PATCH: libc]Re: gnome on current In-Reply-To: <3DBFB627.6BD0B926@mindspring.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 30 Oct 2002, Terry Lambert wrote: > Doug Rabson wrote: > > > > All you have to do is create a situation where a shared object that links > > > > to libc_r is loaded after libX11 and the thing breaks into little pieces. > > > > > > So let's dike out libXThrStub.so, and be done with it. > > > > I think the only stub which it defines that libc.so doesn't also define is > > pthread_cond_broadcast. I'm waiting to see if that lack causes any > > noticeable problems. > > That's bizarre... it's defined in libc_r, so there's no reason for > the omission in libc. I only added stubs that I thought the implementation of libc used (or would use). > Please find attached a patch that corrects this. Patch looks correct. > PS: It looks like the semaphore code use pthread_cond_signal; maybe it > should be using the pthread_cond_broadcast, instead? This seeems to > be broken, if we are talking a large vs. small count on the semaphore... Semaphores only increment/decrement the semaphore by 1. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message