From owner-freebsd-net@freebsd.org  Mon Aug 22 06:07:51 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4DE4BC1B2F
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Mon, 22 Aug 2016 06:07:51 +0000 (UTC)
 (envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [198.74.231.69])
 by mx1.freebsd.org (Postfix) with ESMTP id B72C814E9;
 Mon, 22 Aug 2016 06:07:51 +0000 (UTC)
 (envelope-from rwatson@FreeBSD.org)
Received: from [10.0.1.12] (host109-151-51-164.range109-151.btcentralplus.com
 [109.151.51.164])
 by cyrus.watson.org (Postfix) with ESMTPSA id 1123346B9C;
 Mon, 22 Aug 2016 02:07:49 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: svn commit: r304313 - head/sys/net
From: Robert Watson <rwatson@FreeBSD.org>
In-Reply-To: <16924228-a88c-4d6e-0d51-fedcbec1594d@FreeBSD.org>
Date: Mon, 22 Aug 2016 07:07:46 +0100
Cc: Adrian Chadd <adrian@freebsd.org>,
 FreeBSD Net <freebsd-net@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <92195690-7F54-4395-904F-109D122FFBB1@FreeBSD.org>
References: <201608172021.u7HKLXJ4001584@repo.freebsd.org>
 <CAJ-Vmonu3ZSKZtZZMa68FAS9nDdiriE3iv81cjoW+k3mHKO2=g@mail.gmail.com>
 <28FA9F29-FA29-4547-875D-0734DA120636@FreeBSD.org>
 <CAJ-VmokrNfoJNBoa7iUv0FhQyajAZz2BM7VzaGDu3KVUTmCWUA@mail.gmail.com>
 <16924228-a88c-4d6e-0d51-fedcbec1594d@FreeBSD.org>
To: "Andrey V. Elsukov" <ae@FreeBSD.org>
X-Mailer: Apple Mail (2.2104)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Aug 2016 06:07:51 -0000

On 21 Aug 2016, at 19:18, Andrey V. Elsukov <ae@FreeBSD.org> wrote:

> On 21.08.16 20:33, Adrian Chadd wrote:
>>> Does this make sense?
>>=20
>> Right. Let me go and look into it a little more. I think we may want=20=

>> to revert the change (which just landed to -11, so maybe revert that=20=

>> too) so I can test both of them out for correctness.
>>=20
>> Andrey, I'm sorry for suggesting we back it out, but I'd like to
>> make sure we don't break networking on 11. :) Is that okay? I will
>> look at this tonight/tomorrow.
>=20
> Hi,
>=20
> I already wanted to merge it into releneg/11.0.
>=20
> ...
> I think we can keep this in the release, but if you have an idea how =
to
> improve it - just do it and then do MFC.

I tend to take the view that crashing is worse than not crashing, so we =
should ensure something appears in releng/11.0 that is suitable to ship =
in a release =E2=80=94 at the very least this patch. However, we do need =
to be careful about packet reordering, as it can be extremely hard to =
diagnose while leading to observable performance degradation, which is =
clearly not the goal of enabling higher netisr thread counts. The change =
required to do this properly should be extremely small, and it=E2=80=99s =
worth getting it sorted out and merged for the release, if we can.

Robert=