From owner-cvs-all Fri Dec 4 00:50:20 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA09697 for cvs-all-outgoing; Fri, 4 Dec 1998 00:50:20 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA09685; Fri, 4 Dec 1998 00:50:15 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id TAA14855; Fri, 4 Dec 1998 19:49:50 +1100 Date: Fri, 4 Dec 1998 19:49:50 +1100 From: Bruce Evans Message-Id: <199812040849.TAA14855@godzilla.zeta.org.au> To: ache@nagual.pp.ru, dillon@apollo.backplane.com Subject: Re: cvs commit: src/sys/netinet icmp_var.h Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk >On Thu, Dec 03, 1998 at 08:27:55PM -0800, Matthew Dillon wrote: >> Due to the extern badport_bandlim() I have to keep the #include in >> icmp_var.h ... but it isn't that bad, only three kernel files depend >> on icmp_var.h. I agree that doing the #include'ing in the two C files >> is cleaner, but what to do about the extern then ? > >Even in this variant you can safely remove opt_....h from icmp_var.h and >include it only into really affected *.c files instead (before >icmp_var.h). For kernel files which not needs this stuff but include >icmp_var.h even badport_...() prototype will be not picked which is good. Another rule: - options headers shall not affect the contents of other headers. The extern prototype probably needs to be unconditional. There's no better place for it than icmp_var.h. It's too bad that icmp_var.h isn't actually a file for kernel variables (it mainly gives the API for icmp statistics). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message