From owner-freebsd-acpi@FreeBSD.ORG Tue Nov 20 00:34:09 2007 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0776216A421 for ; Tue, 20 Nov 2007 00:34:09 +0000 (UTC) (envelope-from root@varusonline.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.228]) by mx1.freebsd.org (Postfix) with ESMTP id 474D513C457 for ; Tue, 20 Nov 2007 00:34:08 +0000 (UTC) (envelope-from root@varusonline.com) Received: by wx-out-0506.google.com with SMTP id i29so165755wxd for ; Mon, 19 Nov 2007 16:34:00 -0800 (PST) Received: by 10.70.40.5 with SMTP id n5mr6201655wxn.1195517197406; Mon, 19 Nov 2007 16:06:37 -0800 (PST) Received: from Serval.local ( [24.153.116.131]) by mx.google.com with ESMTPS id i6sm3907784wxd.2007.11.19.16.06.35 (version=SSLv3 cipher=RC4-MD5); Mon, 19 Nov 2007 16:06:35 -0800 (PST) Message-ID: <47422550.8030208@varusonline.com> Date: Mon, 19 Nov 2007 19:07:44 -0500 From: Jessica Mahoney Organization: Varus Online User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Nate Lawson References: <200711192240.lAJMe3Sg075715@freefall.freebsd.org> <200711191819.16152.jhb@freebsd.org> <47421B56.2040809@root.org> In-Reply-To: <47421B56.2040809@root.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org Subject: Re: kern/117591: [acpi][panic] Divide by zero bug in ACPI X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2007 00:34:09 -0000 Nate Lawson wrote: > John Baldwin wrote: > >> On Monday 19 November 2007 05:40:03 pm Jessica Mahoney wrote: >> >>> John Baldwin wrote: >>> > Can you get a stack trace? >>> > >>> > >>> Tracing pid 878 tid 100080 td 0xc3f26440 >>> acpi_battery_get_battinfo(c3a27980,c3ee4d00,e51e1c60,c3ee4d00,0,...) at >>> acpi_battery_get_battinfo+0x26f >>> acpi_battery_ioctl(c0a44203,c3ee4d00,0,c40ec880,e51e1c08,...) at >>> acpi_battery_ioctl+0x14b >>> acpiioctl(c3a9e900,c0a44203,c3ee4d00,3,c3f26440,...) at acpiioctl_0xdd >>> devfs_ioctl_f(c3e35d80,c0a44203,c3ee4d00,c3ee5800,c3f26440,...) at >>> devfs_ioctl_f+0xcb >>> kern_ioctl(c3f26440,3,c0a44203,c3ee4d00,1000a24,..._ at kern_ioctl+0x355 >>> ioctl(c3f26440,e51e1cfc,c,c3f26440,e51e1d2c,...) at ioctl+0x134 >>> syscall(e51e1d38) at syscall+0x345 >>> Xint0x80_syscall() at Xint0x80_syscall+0x20 >>> --- syscall (54, FreeBSD ELF32, ioctl), eip = 0x2815289b, esp = >>> 0xbfbfec3c, ebp = 0xbfbfed28 --- >>> >>> If there's anything else needed, please let me know and I shall provide. >>> >> You can try this: >> >> Index: acpi_battery.c >> =================================================================== >> RCS file: /usr/cvs/src/sys/dev/acpica/acpi_battery.c,v >> retrieving revision 1.25 >> diff -u -r1.25 acpi_battery.c >> --- acpi_battery.c 9 Oct 2007 07:51:46 -0000 1.25 >> +++ acpi_battery.c 19 Nov 2007 23:17:48 -0000 >> @@ -198,8 +198,10 @@ >> */ >> if (bif->units == ACPI_BIF_UNITS_MA && bif->dvol != 0) { >> bst[i].rate = (bst[i].rate * bif->dvol) / 1000; >> +#if 0 >> bst[i].cap = (bst[i].cap * bif->dvol) / 1000; >> bif->lfcap = (bif->lfcap * bif->dvol) / 1000; >> +#endif >> } >> >> /* Calculate percent capacity remaining. */ >> >> I think the mA => mW scaling is resulting in lfcap becoming 0, but since >> all we want is a ratio for 'cap' so we can generate a percentage, we don't >> actually need to scale this. >> > > I think this was already fixed in RELENG_6, 7, and 8-current. Can the > submitter cvsup and try again? > > I just did a cvsup last night, and the issue still persists (hence why I was able to provide a trace). ~Jessica