From owner-svn-src-all@FreeBSD.ORG Tue Mar 24 02:25:20 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1D433B49 for ; Tue, 24 Mar 2015 02:25:20 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 01719385 for ; Tue, 24 Mar 2015 02:25:20 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t2O2PJom091001 for ; Tue, 24 Mar 2015 02:25:19 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t2O2PJd3090996 for svn-src-all@freebsd.org; Tue, 24 Mar 2015 02:25:19 GMT (envelope-from bdrewery) Received: (qmail 21888 invoked from network); 23 Mar 2015 21:25:18 -0500 Received: from unknown (HELO blah) (freebsd@shatow.net@10.10.1.90) by sweb.xzibition.com with ESMTPA; 23 Mar 2015 21:25:18 -0500 Message-ID: <5510CB0E.5010208@FreeBSD.org> Date: Mon, 23 Mar 2015 21:25:18 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rui Paulo , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r280410 - head/sys/kern References: <201503240217.t2O2HHgU052651@svn.freebsd.org> In-Reply-To: <201503240217.t2O2HHgU052651@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2015 02:25:20 -0000 On 3/23/15 9:17 PM, Rui Paulo wrote: > Author: rpaulo > Date: Tue Mar 24 02:17:17 2015 > New Revision: 280410 > URL: https://svnweb.freebsd.org/changeset/base/280410 > > Log: > Disable coredump_devctl because it could lead to leaking paths to > jails. > > Modified: > head/sys/kern/kern_sig.c > > Modified: head/sys/kern/kern_sig.c > ============================================================================== > --- head/sys/kern/kern_sig.c Tue Mar 24 01:32:46 2015 (r280409) > +++ head/sys/kern/kern_sig.c Tue Mar 24 02:17:17 2015 (r280410) > @@ -180,7 +180,7 @@ static int set_core_nodump_flag = 0; > SYSCTL_INT(_kern, OID_AUTO, nodump_coredump, CTLFLAG_RW, &set_core_nodump_flag, > 0, "Enable setting the NODUMP flag on coredump files"); > > -static int coredump_devctl = 1; > +static int coredump_devctl = 0; > SYSCTL_INT(_kern, OID_AUTO, coredump_devctl, CTLFLAG_RW, &coredump_devctl, > 0, "Generate a devctl notification when processes coredump"); > > If there is a security concern about this feature I think more needs to be done than just flipping the default. It could easily be forgotten about and make a release. -- Regards, Bryan Drewery