From owner-cvs-all@FreeBSD.ORG Mon Oct 17 18:31:44 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A06816A420; Mon, 17 Oct 2005 18:31:44 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71A4743D49; Mon, 17 Oct 2005 18:31:43 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9HIVhO2000653; Mon, 17 Oct 2005 11:31:43 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9HIVhFO000651; Mon, 17 Oct 2005 11:31:43 -0700 (PDT) (envelope-from obrien) Date: Mon, 17 Oct 2005 11:31:39 -0700 From: "David O'Brien" To: Jung-uk Kim Message-ID: <20051017183139.GA97488@dragon.NUXI.org> References: <200510160858.j9G8wR9v045670@repoman.freebsd.org> <200510171200.49522.jkim@FreeBSD.org> <20051017172828.GB97278@dragon.NUXI.org> <200510171417.38095.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510171417.38095.jkim@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 identcpu.c src/sys/i386/i386 identcpu.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2005 18:31:44 -0000 On Mon, Oct 17, 2005 at 02:17:33PM -0400, Jung-uk Kim wrote: > On Monday 17 October 2005 01:28 pm, David O'Brien wrote: > > On Mon, Oct 17, 2005 at 12:00:47PM -0400, Jung-uk Kim wrote: > > > On Sunday 16 October 2005 04:58 am, David E. O'Brien wrote: > > > > obrien 2005-10-16 08:58:27 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/amd64/amd64 identcpu.c > > > > sys/i386/i386 identcpu.c > > > > Log: > > > > For AMD processors, nullify CPUID.HTT. FreeBSD has no need > > > > for the information it conveys, and it is only confusing > > > > people. This fixes incorrect output in the previous commit. > > > > > > > > Revision Changes Path > > > > 1.138 +9 -0 src/sys/amd64/amd64/identcpu.c > > > > 1.147 +9 -0 src/sys/i386/i386/identcpu.c > > > > > > Have you verified you are not breaking `logical_cpus' in > > > mp_machdep.c by doing this? > > > > > > Show me the 'incorrect' output or please back it out. > > > > CPU: Dual Core AMD Opteron(tm) Processor 280 (2392.35-MHz > > K8-class CPU) .. > > Physical/Logical cores: 2/2 > > .. > > FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs > > cpu0 (BSP): APIC ID: 0 > > cpu1 (AP): APIC ID: 1 > > cpu2 (AP): APIC ID: 2 > > cpu3 (AP): APIC ID: 3 > > > > I sure as hell have 4 physical cores and no logical cores. > > The information is per-CPU. You have two CPUs with dual cores, which > means the given information is correct. Please back it out. No, this given information is wrong. AMD does not have HyperThreading. You are treating it as if it does. The rest of the kernel also should not be trying to treat AMD dual-core as HyperThreading. The only thing that should care in the freebsd kernel right now about AMD dual-core is PowerNow! support. It probably needs to know what cores match physical cores so it can proper work in a multi-socket system. Please point to what part of `logical_cpus' in mp_machdep.c you feel is broken by this change. > > I do not think you fully understand what AMD dual-core CPU's. > > Oh, please... The code you committed suggest this... -- -- David (obrien@FreeBSD.org)