From owner-freebsd-ports@FreeBSD.ORG Wed Nov 16 16:55:37 2005 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50D4C16A41F for ; Wed, 16 Nov 2005 16:55:37 +0000 (GMT) (envelope-from swhetzel@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7C3B43D46 for ; Wed, 16 Nov 2005 16:55:36 +0000 (GMT) (envelope-from swhetzel@gmail.com) Received: by xproxy.gmail.com with SMTP id s9so1116221wxc for ; Wed, 16 Nov 2005 08:55:36 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=grXcyPFOA60fWNpqDDmHo0tko9CS10HlEXClCMUvrPQEtwlMGWIWV3FtPEsnPc50zogpH6PkGfF1gE5IYgcATS6AN9aHiPx9J3K6ObF5kG+CAqP7Yy5sPAJAV10AM7TtoEiJE4k/prEtXYWPvnwksgm5NoCdDJCqHa48KDSmO9M= Received: by 10.70.54.2 with SMTP id c2mr4058203wxa; Wed, 16 Nov 2005 08:27:48 -0800 (PST) Received: by 10.70.31.5 with HTTP; Wed, 16 Nov 2005 08:27:48 -0800 (PST) Message-ID: <790a9fff0511160827g183c5267v4980deaf22eded02@mail.gmail.com> Date: Wed, 16 Nov 2005 10:27:48 -0600 From: Scot Hetzel To: Craig Boston In-Reply-To: <20051115212859.GA71557@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200511151154.32536.ringworm01@gmail.com> <790a9fff0511151300k51a95084sc8f97181d88e1022@mail.gmail.com> <200511151301.16549.ringworm01@gmail.com> <20051115212859.GA71557@nowhere> Cc: freebsd-ports@freebsd.org, Jiawei Ye Subject: Re: Why does security/amavisd-new depend on db3? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2005 16:55:37 -0000 On 11/15/05, Craig Boston wrote: > On Tue, Nov 15, 2005 at 01:01:15PM -0800, Michael C. Shultz wrote: > > This would still be wrong: > > > > .if ${.CURDIR} =3D=3D /usr/ports/databases/p5-BerkleyDB > > WITH_BDB_VER?=3D42 > > .endi > > > > It is equivalent to: > > > > in pkgtools.conf: > > MAKE_ARGS =3D { > > 'databases/p5-BerkeleyDB' =3D> 'WITH_BDB_VER=3D42', > > > > in pm-020.conf > > databases/p5-BerkeleyDB|WITH_BDB_VER=3D42| > > Actually, those are not quite equivalent. The make.conf entry should > work around the problem. See below for details. > > > Maybe you mean to set it as a global > > value ie. without the .if ${.CURDIR} =3D=3D /usr/ports/databases/p5-Ber= kleyDB > > wrapper? If that were the case it would still have no effect on > > security/amavisd-new where the incorrect dependency is being recorded, > > see for yourself: > > > > > cd /usr/ports/security/amavisd-new > > /usr/ports/security/amavisd-new>grep WITH Makefile > > > > .if !defined(WITH_MILTER) || (!exists(/usr/lib/libmilter.a) > > && !exists(${PREFIX}/lib/libmilter.a)) > > .if defined(WITH_MILTER) && !defined(AMAVIS_NOAMAVIS) > > .if defined(WITH_MYSQL) > > .if defined(WITH_PGSQL) > > .if defined(WITH_LDAP) > > It would work either as a global or with the CURDIR trick, due to the > way that the dependencies are being generated. It's true that the > amavisd-new Makefile itself is unaffected by WITH_BDB_VER, but the > p5-BerkeleyDB Makefile _IS_ evaluated at some point during the install of > amavisd-new (regardless of whether it was already installed during that > step or not). > > During the install phase of amavisd-new, the +CONTENTS file is generated > in part from the output of "make package-depends-list" > > What package-depends-list does, is that for each of the LIB_DEPENDS and > RUN_DEPENDS, it will do the equivalent of this pseudo-code: > > cd ${DEPEND_PORT_DIR} && make package-depends-list > > And will then print out each of its own LIB_DEPENDS and RUN_DEPENDS at > the end. The effect is that each dependent port gets visited and > evaluated, all the way up the chain (so dependencies of dependencies get > visited, etc.), and a list of all deps is produced. > > Since this all happens at install time, if portmanager or portupgrade > did not set WITH_BDB_VER in the environment before trying to install > *amavisd*, the dependencies will be wrong. The MAKE_ARGS and such don't > take effect because those tools don't know that those port directories > are being visited (it all happens during a single "make install"). > > make.conf, however, does get evaluated at every step of the way. So > when the recursive makes are processed, and the dependencies for > p5-BerkeleyDB are being queried, that variable will kick in (since > CURDIR contains databases/p5-BerkeleyDB at that point). > > Craig > Thanks for taking the time to explain the problem further, I was trying to, but had only a few minutes to formulate my answer. Scot -- DISCLAIMER: No electrons were mamed while sending this message. Only slightly bruised.