From owner-freebsd-transport@freebsd.org Fri Feb 19 19:58:44 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6A3E253A14C for ; Fri, 19 Feb 2021 19:58:44 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dj2T01dvjz3CPk for ; Fri, 19 Feb 2021 19:58:44 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 381AB53A406; Fri, 19 Feb 2021 19:58:44 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 37C0453A38E for ; Fri, 19 Feb 2021 19:58:44 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dj2T00qMWz3CBV; Fri, 19 Feb 2021 19:58:44 +0000 (UTC) (envelope-from gjb@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1613764724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zSf7nVAEBeE3Dzv/qCrto5d/wcPi3TbA+km4nwNPXV4=; b=ayOtbk2RdXdcpKwmiM5I/83CRXCq9rIJpSXp6jD+1cjy7EWF2112o8HbFWvbVKGoXz5RRf 3gNNK603+g906O7FcuXyvAYCSpM/+KSDRUtRyUw/+UZKvm+ch+ViGbqpN9PIcvsdZu8T8G heoVC6Q4ToCVeqv4IGuiwl6smx6F3sksJbEaygwvVVAO9nIRyXQwwoS/nfFY+KcPneKvoM WdOH5etClzL3fL5cF4QQRBlJ9WCU4p4JvwkLECSPiBe+0Nj5a+eJabE8RXlRR5n8TXTsB1 kUkOyAhSfzcvl9j6kNzI7iAEmZ/0eIPKIehoSQUXKY3OsAmLODInGiWeVN/5vw== Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 98C176A19; Fri, 19 Feb 2021 19:58:43 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Fri, 19 Feb 2021 19:58:41 +0000 From: Glen Barber To: "Scheffenegger, Richard" Cc: "re@freebsd.org" , "transport@freebsd.org" Subject: Re: approval for D28780 / 853fd7a2e39802e46bd3d6476529796ac22412d9 Message-ID: <20210219195841.GW48055@FreeBSD.org> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TVVcQco/7vcH19KK" Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1613764724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zSf7nVAEBeE3Dzv/qCrto5d/wcPi3TbA+km4nwNPXV4=; b=wRbGrPh+Q2bV/N+2wqL+dAK7xC+pI1AhFLtZYQOYbUku6lNFkd6TxFimrYJrlEOKqix4yU l9RWFXE9nrdCmnnFJR/olcIoq2INPSgNJh9z+pT5WDt0mgl0TB3pg89ysdxD+9yubzi8bc ZK983TfKrO5uhlbSecS66BsLKnakz5/+aRPvT3S6NiW2CsEQqF/imcTzg+ydm4JkdgtqUQ 5mTlPv405tM6U+GFoCvpYht/GaAoDwoDJ3NoL1oFLY6p+7OgxGm+u67zrAHREG8hsq9M0Z hOBbsWJjG1xVi8qHh3eSK54Vg0u/MirdhO+prX3etOoeod7yvu7LOe539O84kQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1613764724; a=rsa-sha256; cv=none; b=G67+Zih+7bCHKiubKV+jDq8ATZpK4h5iaJ6sJVRjBwHdyKA7w4WTA5Tp+wv+Jj7eCANxFm XoBZH8nWUoTTXjkDodhw/TFNpyYo32MN8JspMEBP6rIs7mS2ogW+xnGnqzPn39YsD61zvp bSNHxxSIGvvqKR2mbD+B0xTAhc5WKRXl+PK5ETHrhum+iUeMQJBG6J4pC+aEraiA1Km4yM wGQhoKFKafDUN6ydi/iYEHPo9s2TbA5LB6lA7z6uBTJrWE3cu0ZzcK0i3hGiwggncCny0k ImNz66PCVPdU3oXW/XX1Q5ZYwVm59pjW26ade8G7GIeAmlNyxpAsWITjT8FOdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 19:58:44 -0000 --TVVcQco/7vcH19KK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 19, 2021 at 01:48:22PM +0000, Scheffenegger, Richard wrote: > Hi Glen, >=20 > I received feedback around PRR which shows up as a performance degradatio= n. >=20 > I would like to MFC this commit in about one week into STABLE/13, and ide= ally to releng/13.0 around the same time (or should there be at least 3 day= s linger time in STABLE, after one week in HEAD)? >=20 > https://reviews.freebsd.org/D28780 >=20 >=20 > Under some circumstances, PRR may end up with a fully > collapsed cwnd when finalizing the loss recovery. >=20 > Also, in case PRR is working against an empty scoreboard, > a possibilty for an integer overflow exists. Performing > signed arithmetics to address a possible sudden jump of cwnd. >=20 Send us the change request following the guidelines when you are ready to request the approval. https://wiki.freebsd.org/Releng/ChangeRequestGuidelines Glen --TVVcQco/7vcH19KK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAmAwGHEACgkQAxRYpUeP 4pPVhw/8D2rILozKZcv64uowqKelVFe9zCHj73mV5U+vrH2NQdmW12c5UrzzmoGw VhuvNLYPSb5eEP9WGPM22JkGM+G9Hh3hdnG9Mf13gNCNXkLTBikBfKErGxUPgHRT Oq+fNvT4S3ZstVkKsVD/SHVV5/9tdA2SA8QTTTpoHVn2ni0v3sCkbRApUOYMAyln bCoWVjwQMgQgco1XmHW9WeywjctF89t37VjakZ3llw7iXTGJke6qK1fYR2R4/7t2 uyjXJyLnC+FM+jEOphN/J4TfI610ZAEwOulicQOdkf5lKLhKsvVWH5vNClKGBtyG Q9cdWPeq8sZXhdl5vMaWFtwReWF2WWn0foZzvxRIqPR80wm1fz+Ac8Dwa8SYNykY uVHuH5yLHfSafdkxdI97VJt03Pv7iZxFQ9CGych1w86pKYHPpDIQQHyNBAjqOlqU G41fY3a3uFV+wnxFN6UvdvDbPXBcGHlI1L0xifT5fjCFrfj72kpzKm3zWnUDi0ik zOw25lRC5F+zJ683mWWR2VcgqGcRedGdKF4g24k1oChTIZpFnE3IfQK/9K9vk6E8 u7+j0F5aLToFI5w8n3PNEUL8SbWvWq3F9OFY8CPKbgBq6h6gdSAizJs9mGlg1OKg CKNpbordezqc/1xHWx1oqrYUrIR+rh4SeuvSKFsO/1A4P+/7wws= =X4bb -----END PGP SIGNATURE----- --TVVcQco/7vcH19KK--