From owner-freebsd-current@FreeBSD.ORG Mon Sep 20 21:38:17 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6AAC116A4CE for ; Mon, 20 Sep 2004 21:38:17 +0000 (GMT) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7CFA43D2D for ; Mon, 20 Sep 2004 21:38:16 +0000 (GMT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru id i8KLZ7PY065362 for freebsd-current@FreeBSD.org.checked; (8.12.8/vak/2.1) Tue, 21 Sep 2004 01:35:07 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by hanoi.cronyx.ru with ESMTP id i8KLWgQM065236; (8.12.8/vak/2.1) Tue, 21 Sep 2004 01:32:42 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <414F4AAC.5000807@cronyx.ru> Date: Tue, 21 Sep 2004 01:25:00 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.2.1) Gecko/20030426 X-Accept-Language: ru-ru, en MIME-Version: 1.0 To: John Baldwin References: <41421D6A.8070805@cronyx.ru> <414E7581.2070505@root.org> <414F256B.1030304@cronyx.ru> <200409201652.24457.jhb@FreeBSD.org> In-Reply-To: <200409201652.24457.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Roman Kurakin cc: FreeBSD Current cc: Nate Lawson Subject: Re: mp_machdep.c (was Re: [Fwd: Re: Bug reports requested - acpi]) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 21:38:17 -0000 John Baldwin: >On Monday 20 September 2004 02:46 pm, Roman Kurakin wrote: > > >>Hi, >> >> I have problem with one of my SMP systems (see end of letter). >>It looks that following patch: >> >>Index: mp_machdep.c >>=================================================================== >>RCS file: /home/ncvs/src/sys/i386/i386/mp_machdep.c,v >>retrieving revision 1.238 >>diff -u -r1.238 mp_machdep.c >>--- mp_machdep.c 1 Sep 2004 06:42:01 -0000 1.238 >>+++ mp_machdep.c 20 Sep 2004 18:20:49 -0000 >>@@ -747,6 +747,11 @@ >> POSTCODE(INSTALL_AP_TRAMP_POST); >> >> pmap_kenter(boot_address + KERNBASE, boot_address); >>+#ifdef I386_CPU >>+ invltlb(); >>+#else >>+ invlpg((u_int)dst); >>+#endif >> for (x = 0; x < size; ++x) >> *dst++ = *src++; >> >>solves the problem. I'll check it on not very recent hacked current. >>So this is initial request. I'll check it with current current without my >>hacks to double check that this works always and inform if this helps. >> >> The intent of this letter to ask community if this workaround for my >>problem or real bug fix. If this is only workaround please let me know >>and I'll continue to dig with version I currently use. >>(I don't like workarounds) >> >>Best regards, >> Roman Kurakin >> >> > >It's probably cleaner to use pmap_invalidate_range(). Something like: > Hm, what about pmap_invalidate_page () or even pmap_map () ? Index: mp_machdep.c =================================================================== RCS file: /usr/cvs/src/sys/i386/i386/mp_machdep.c,v retrieving revision 1.238 diff -u -r1.238 mp_machdep.c --- mp_machdep.c 1 Sep 2004 06:42:01 -0000 1.238 +++ mp_machdep.c 20 Sep 2004 20:50:35 -0000 @@ -738,15 +738,15 @@ int x; int size = *(int *) ((u_long) & bootMP_size); u_char *src = (u_char *) ((u_long) bootMP); u_char *dst = (u_char *) boot_address + KERNBASE; u_int boot_base = (u_int) bootMP; u_int8_t *dst8; u_int16_t *dst16; u_int32_t *dst32; POSTCODE(INSTALL_AP_TRAMP_POST); - pmap_kenter(boot_address + KERNBASE, boot_address); + pmap_map((vm_offset_t)dst, boot_address, boot_address + size, 0); for (x = 0; x < size; ++x) *dst++ = *src++; >It seems odd that this is needed though. Does it go away if you use >DISABLE_PSE or DISABLE_PGE? > I'll check this. rik