From owner-svn-src-head@FreeBSD.ORG Thu Apr 4 15:20:53 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id BF47FD88; Thu, 4 Apr 2013 15:20:53 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) by mx1.freebsd.org (Postfix) with ESMTP id 4CF739C7; Thu, 4 Apr 2013 15:20:52 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.6/8.14.6) with ESMTP id r34FKkMn000603; Thu, 4 Apr 2013 19:20:46 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.6/8.14.6/Submit) id r34FKkBt000602; Thu, 4 Apr 2013 19:20:46 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 4 Apr 2013 19:20:46 +0400 From: Gleb Smirnoff To: "George V. Neville-Neil" , rmacklem@FreeBSD.org Subject: Re: svn commit: r249096 - head/sys/rpc/rpcsec_gss Message-ID: <20130404152046.GO76816@FreeBSD.org> References: <201304041516.r34FGsgo097962@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201304041516.r34FGsgo097962@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2013 15:20:53 -0000 George, Rick, On Thu, Apr 04, 2013 at 03:16:54PM +0000, George V. Neville-Neil wrote: G> Modified: head/sys/rpc/rpcsec_gss/rpcsec_gss_prot.c G> ============================================================================== G> --- head/sys/rpc/rpcsec_gss/rpcsec_gss_prot.c Thu Apr 4 15:03:12 2013 (r249095) G> +++ head/sys/rpc/rpcsec_gss/rpcsec_gss_prot.c Thu Apr 4 15:16:53 2013 (r249096) G> @@ -208,6 +208,8 @@ m_trim(struct mbuf *m, int len) G> struct mbuf *n; G> int off; G> G> + if (m == NULL) G> + return; G> n = m_getptr(m, len, &off); G> if (n) { G> n->m_len = off; I think the code will be much more rocksolid, if the function won't be called with NULL argument. -- Totus tuus, Glebius.