Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Feb 2003 14:32:22 +1100
From:      Tim Robbins <tjr@FreeBSD.org>
To:        Marcel Moolenaar <marcel@xcllnt.net>
Cc:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/bin/sh machdep.h memalloc.c nodes.c.pat
Message-ID:  <20030218143222.A21049@dilbert.robbins.dropbear.id.au>
In-Reply-To: <20030218022850.GB1973@athlon.pn.xcllnt.net>; from marcel@xcllnt.net on Mon, Feb 17, 2003 at 06:28:51PM -0800
References:  <200302180208.h1I28Kbu046465@repoman.freebsd.org> <20030218022850.GB1973@athlon.pn.xcllnt.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 17, 2003 at 06:28:51PM -0800, Marcel Moolenaar wrote:

> On Mon, Feb 17, 2003 at 06:08:20PM -0800, Tim J. Robbins wrote:
> > tjr         2003/02/17 18:08:20 PST
> > 
> >   Modified files:
> >     bin/sh               memalloc.c nodes.c.pat 
> >   Added files:
> >     bin/sh               machdep.h 
> >   Log:
> >   Revert ALIGN change for the second and last time. I can't figure out
> >   why this is breaking sparc64.
> 
> Hmmm.... Maybe this is what's breaking ia64 as well. I just bumped
> _ALIGNBYTES from 7 to 15 and the argument passing seems to be
> screwed. Is that that what you see as well?

Not quite, the "\320" chars from malloc()'s J flag were being appearing
in places. On panther:
install-info --quiet  --defsection="Gcc Documentation"  --defentry="* cppinternals: (cppinternals).             The GNU compiler preprocessor internal documentation."  cppinternals.info /usr/share/info/dir
install-info: excess command line argument `/usr/share/info/dir'
install-info: No such file or directory for 行行行行行行行行
*** Error code 1


I think the problem could have been that the initial stack block
in memalloc.c wasn't being aligned correctly, which I overlooked
when adding the alignment stuff to stalloc():

char *stacknxt = stackbase.space;
int stacknleft = MINSIZE;

Try this (ugly) patch: http://people.freebsd.org/~tjr/align.diff


Tim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030218143222.A21049>