Date: Wed, 31 Oct 2012 12:42:39 -0700 From: Jim Harris <jim.harris@gmail.com> To: Peter Jeremy <peter@rulingia.com> Cc: Attilio Rao <attilio@freebsd.org>, svn-src-head@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r242402 - in head/sys: kern vm Message-ID: <CAJP=Hc8hXXuDkr00z9hSR30PmKJAOh29MCm2kC%2BJvB2u6O4G0A@mail.gmail.com> In-Reply-To: <20121031193020.GJ3309@server.rulingia.com> References: <201210311807.q9VI7IcX000993@svn.freebsd.org> <CAJ-FndDRkBS57e9mzZoJWX5ugJ0KBGxhMSO50KB8Wm8MFudjCA@mail.gmail.com> <1351707964.1120.97.camel@revolution.hippie.lan> <CAJ-FndC7QwpNAjzQTumqTY6Sj_RszXPwc0pbHv2-pRGMqbw0ww@mail.gmail.com> <CAJ-VmokqEFX4wQYh-ojo3kcWUPj5L-V_k0Nj-u3sQByVypkDFw@mail.gmail.com> <CAJ-FndCL7bpkbfaaR%2BaYQAxEBDmgip0QbrE5JhwnbTicSraz9g@mail.gmail.com> <20121031193020.GJ3309@server.rulingia.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 31, 2012 at 12:30 PM, Peter Jeremy <peter@rulingia.com> wrote: > On 2012-Oct-31 18:57:37 +0000, Attilio Rao <attilio@FreeBSD.org> wrote: > >On 10/31/12, Adrian Chadd <adrian@freebsd.org> wrote: > >> Right, but you didn't make it configurable for us embedded peeps who > >> still care about memory usage. > > > >How is this possible without breaking the module/kernel ABI? > > Memory usage may override ABI compatibility in an embedded environment. > > >All that assuming you can actually prove a real performance loss even > >in the new cases. > > The issue with padding on embedded systems is memory utilisation rather > than performance. Agree that for embedded systems, we need to be careful about proliferating this throughout the entire kernel. But for the usages thus far, Attilio is right that they should not affect UP. The ULE and callout changes made very recently are on per-CPU data structures, so for UP, that's padding just one mutex each. For the vpglock->mtx_padalign conversion, this is functionally a nop. vpglock was already doing this padding. -Jim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJP=Hc8hXXuDkr00z9hSR30PmKJAOh29MCm2kC%2BJvB2u6O4G0A>