From owner-freebsd-bugs@FreeBSD.ORG  Sun Mar 11 04:50:05 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0713316A403
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 11 Mar 2007 04:50:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id C171713C471
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 11 Mar 2007 04:50:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l2B4o4jW095382
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 11 Mar 2007 04:50:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l2B4o4QX095381;
	Sun, 11 Mar 2007 04:50:04 GMT (envelope-from gnats)
Resent-Date: Sun, 11 Mar 2007 04:50:04 GMT
Resent-Message-Id: <200703110450.l2B4o4QX095381@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Alex Kozlov<spam@rm-rf.kiev.ua>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 847D616A41F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 11 Mar 2007 04:43:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 7392C13C4A7
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 11 Mar 2007 04:43:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l2B4hWmA064141
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2007 04:43:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l2B4hWW5064140;
	Sun, 11 Mar 2007 04:43:32 GMT (envelope-from nobody)
Message-Id: <200703110443.l2B4hWW5064140@www.freebsd.org>
Date: Sun, 11 Mar 2007 04:43:32 GMT
From: Alex Kozlov<spam@rm-rf.kiev.ua>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.0
Cc: 
Subject: bin/110178: [patch] Fix handling of -n option in /sbin/mdmfs
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Mar 2007 04:50:05 -0000


>Number:         110178
>Category:       bin
>Synopsis:       [patch] Fix handling of -n option in /sbin/mdmfs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 11 04:50:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Alex Kozlov
>Release:        FreeBSD 6.2
>Organization:
private
>Environment:
>Description:
mdmfs describes -n option as 'rotational-positions' but in newfs it means 'do not create a .snap directory'
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- mdmfs.c
+++ mdmfs.c.new
@@ -127,7 +127,7 @@
 	}
 
 	while ((ch = getopt(argc, argv,
-	    "a:b:Cc:Dd:E:e:F:f:hi:LlMm:Nn:O:o:Pp:Ss:t:Uv:w:X")) != -1)
+	    "a:b:Cc:Dd:E:e:F:f:hi:LlMm:NnO:o:Pp:Ss:t:Uv:w:X")) != -1)
 		switch (ch) {
 		case 'a':
 			argappend(&newfs_arg, "-a %s", optarg);
@@ -188,7 +188,7 @@
 			norun = true;
 			break;
 		case 'n':
-			argappend(&newfs_arg, "-n %s", optarg);
+			argappend(&newfs_arg, "-n");
 			break;
 		case 'O':
 			argappend(&newfs_arg, "-o %s", optarg);
@@ -655,10 +655,10 @@
 {
 
 	fprintf(stderr,
-"usage: %s [-DLlMNPSUX] [-a maxcontig] [-b block-size]\n"
+"usage: %s [-DLlMNnPSUX] [-a maxcontig] [-b block-size]\n"
 "\t[-c blocks-per-cylinder-group][-d max-extent-size] [-E path-mdconfig]\n"
 "\t[-e maxbpg] [-F file] [-f frag-size] [-i bytes] [-m percent-free]\n"
-"\t[-n rotational-positions] [-O optimization] [-o mount-options]\n"
+"\t[-O optimization] [-o mount-options]\n"
 "\t[-p permissions] [-s size] [-v version] [-w user:group]\n"
 "\tmd-device mount-point\n", getprogname());
 	exit(1);

>Release-Note:
>Audit-Trail:
>Unformatted: