From owner-cvs-src@FreeBSD.ORG Thu Apr 21 10:53:41 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FFA116A4CE; Thu, 21 Apr 2005 10:53:41 +0000 (GMT) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE79743D1F; Thu, 21 Apr 2005 10:53:40 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j3LArcNG071732; Thu, 21 Apr 2005 14:53:39 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j3LArcV6071731; Thu, 21 Apr 2005 14:53:38 +0400 (MSD) (envelope-from yar) Date: Thu, 21 Apr 2005 14:53:37 +0400 From: Yar Tikhiy To: Doug Ambrisko Message-ID: <20050421105337.GD69054@comp.chem.msu.su> References: <200504202351.j3KNpWlH057707@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504202351.j3KNpWlH057707@repoman.freebsd.org> User-Agent: Mutt/1.5.9i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-dma.c ata-pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2005 10:53:41 -0000 On Wed, Apr 20, 2005 at 11:51:32PM +0000, Doug Ambrisko wrote: > ambrisko 2005-04-20 23:51:32 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_4) > sys/dev/ata ata-all.c ata-all.h ata-dma.c ata-pci.c > Log: > Add in Promise and Intel SATA support based on FreeBSD 5.X ATAng. > This gets the HW to work but not to deal with SATA errors. So if > the drive has a read error it will probably lock up. This is > a small subset of my patches that do deal with these errors and > other issues in FreeBSD and ata-raid. > > Sponsored by: IronPort Systems > > Revision Changes Path > 1.50.2.49 +168 -36 src/sys/dev/ata/ata-all.c > 1.26.2.15 +166 -13 src/sys/dev/ata/ata-all.h > 1.35.2.39 +95 -17 src/sys/dev/ata/ata-dma.c > 1.32.2.22 +164 -18 src/sys/dev/ata/ata-pci.c I myself was bitten by RELENG_4 ATA support lagging behind modern hardware, which made me move to RELENG_5 on some systems at last. However, isn't your change too big and possibly destabilizing for the conservative RELENG_4 branch? I'm judging by the number of changed lines only. And honestly, I'm having trouble understanding from the commit message whether your change introduces or corrects the bug in SATA error detection. Would you mind commenting on these two issues? Thanks a lot! -- Yar