From owner-svn-src-all@FreeBSD.ORG Tue Mar 30 15:34:04 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B0571065674; Tue, 30 Mar 2010 15:34:04 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f225.google.com (mail-fx0-f225.google.com [209.85.220.225]) by mx1.freebsd.org (Postfix) with ESMTP id C912B8FC20; Tue, 30 Mar 2010 15:34:02 +0000 (UTC) Received: by fxm25 with SMTP id 25so14503fxm.3 for ; Tue, 30 Mar 2010 08:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=ME3YYJpuldxHq0AqIV2ecNDZVS1QeFJLuslHlT2s2Qg=; b=REfQLw0PkbmaBhIZR25T/tVQ3zGnNaC/M/XfU3HPvti5b6SkfTr9NO+IHtSUfyeBQQ G79z3GjLIhz7we0EOWJVyP495NNp1BUPi1ITH/cSsIxezMC3k5pXeYjzaTP8WwYpKvhs 1RCItuEZ/l3ZfyniyLk091m3D/V07Ax+MYW2s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=iCS8ZLpFlWXuwQANza5BwAJOChFTVPTVfqnssatXevBOlu0CUtVMEYOM/jWpwpDl+b m9NDkwtkBpk+ryzyJ2XgsBbzImOKqd2cJ8mtpk6mfyxywX0yoEW7rZxqWcH96EuZrZXG GgZ81DgteJiqCkND7GBAMDfbCVyGG5bO4EI8s= Received: by 10.223.7.91 with SMTP id c27mr7165354fac.19.1269962799070; Tue, 30 Mar 2010 08:26:39 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id 14sm4021922fxm.1.2010.03.30.08.26.37 (version=SSLv3 cipher=RC4-MD5); Tue, 30 Mar 2010 08:26:38 -0700 (PDT) Sender: Alexander Motin Message-ID: <4BB2182C.4080203@FreeBSD.org> Date: Tue, 30 Mar 2010 18:26:36 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Bruce Cran References: <201003131117.o2DBHek2003410@svn.freebsd.org> In-Reply-To: <201003131117.o2DBHek2003410@svn.freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205119 - head/contrib/top X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 15:34:04 -0000 Bruce Cran wrote: > Author: brucec > Date: Sat Mar 13 11:17:39 2010 > New Revision: 205119 > URL: http://svn.freebsd.org/changeset/base/205119 > > Log: > Change the 'amt' parameter in format_k2 from int to unsigned long long > to match the values passed in and prevent the SIZE field being corrupted > when more than 2TB is allocated. This change seems broke top on ARM, as declaration in util.h doesn't specifies argument type, and caller assumes int there. To make it work correctly, second part should be done: --- top.prev/utils.h 2009-10-14 15:23:42.000000000 +0300 +++ top/utils.h 2010-03-30 18:14:11.000000000 +0300 @@ -21,4 +21,4 @@ long percentages(); char *errmsg(); char *format_time(); char *format_k(); -char *format_k2(); +char *format_k2(unsigned long long); -- Alexander Motin