Date: Fri, 10 Aug 2012 18:34:01 +0100 From: Chris Rees <crees@freebsd.org> To: Kevin Oberman <kob6558@gmail.com>, "b. f." <bf1783@gmail.com>, tor-dev@torproject.org Cc: Jordi Espasa Clofent <jespasac@minibofh.org>, freebsd-ports@freebsd.org Subject: Re: tcmalloc in Tor FreeBSD port Message-ID: <CADLo83_-jcDiPErMwZMhzozpFxkDVr67M=Cp4-qMMGMVLBJx5A@mail.gmail.com> In-Reply-To: <CAN6yY1tq3r8TOeSFz9WOTkb1cU7kuk5iXajqJ4tLXBwQa1iZ1A@mail.gmail.com> References: <5025228E.5030705@minibofh.org> <CAN6yY1tq3r8TOeSFz9WOTkb1cU7kuk5iXajqJ4tLXBwQa1iZ1A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Forwarding to tor-dev mailing list; this is their problem. On 10 August 2012 18:15, Kevin Oberman <kob6558@gmail.com> wrote: > On Fri, Aug 10, 2012 at 8:02 AM, Jordi Espasa Clofent > <jespasac@minibofh.org> wrote: >> Hi all, >> >> Please, read the follow thread in tor-dev to be in the loop: >> https://lists.torproject.org/pipermail/tor-dev/2012-August/003878.html >> >> I tried to contact the mantainer according to Makefile and Freshports, but I >> didn't receive any answer. So I guess this mail-list is probably the most >> accurate place to ask. > > First, bf is typically pretty active, so he (she?) must be away or you > would have heard from him (her?) He :) > Looks like this broke when the port was converted to use OPTIONSNG > about two months ago. I am not a make wizard or even close to it, but > the options code is clearly not doing what it's supposed to be doing. > You can probably roll the Makefile back to r297464, edit the > DISTVERSION to "DISTVERSION= 0.2.2.37", remove the > "ftp://ftp.fodt.it/pub/mirror/tor/dist/ \" line, keep the rest of the > existing port, and build it. > > If I get a few minutes, I will see if I can figure out why the options > are not working after the change to OPTIONSNG. I have a port htat I > really need to convert to OPTIONSNG, so maybe I'll get that done, too. Brendan's code in the port is perfectly fine. The configure.in is where the problem lies; if test x$tcmalloc = xyes ; then using_custom_malloc=yes fi if test $using_custom_malloc = no ; then AC_CHECK_FUNCS(mallinfo malloc_good_size malloc_usable_size) fi ^^^ this stanza is included before $tcmalloc is set; examine where it is set in configure further down; # Check whether --with-tcmalloc was given. if test "${with_tcmalloc+set}" = set; then : withval=$with_tcmalloc; tcmalloc=yes else tcmalloc=no fi Oops! The result is that using_custom_malloc will never be set to yes, and tcmalloc will probably never be used. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_-jcDiPErMwZMhzozpFxkDVr67M=Cp4-qMMGMVLBJx5A>