From owner-freebsd-ports@FreeBSD.ORG Fri Aug 10 17:34:36 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E57B106566C for ; Fri, 10 Aug 2012 17:34:36 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id D75D88FC0C for ; Fri, 10 Aug 2012 17:34:35 +0000 (UTC) Received: by bkcje9 with SMTP id je9so723027bkc.13 for ; Fri, 10 Aug 2012 10:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=LSYpG6ujsZUdwF9TzXckotqK5sRW+EoPshthyVTr1UU=; b=GH+egAybt07fAYoR+Ds0CRhhcvK1slhC5vI04YazKwUTwtRjAZJqAi+ReLDeM4XfgA yQmdupKTty/NUdGZ2Xy1m4exaQdWupVHz6zeqO5qSErU2NPWg0ZAjJC8vxw5CpaTPKPK 3dc0XEqxVmh94jG+rWrzTgJO9BttpA1JJFZbYVg40G1hw1HRAJjSi1UFlECHlHGg9JD8 QZbqy3AE08iH9Qgcj8cRI2jNAXtojEDLTrY4/KE7MzzoFMyaid2mwd4j8jnybhVUQWw8 8OC7Zgb5/orrjBS+ERzuopRGvKmIfDq3DIGI6athoioSPrpqac+hVu1xEdVU7mVWuOVO Jsbg== Received: by 10.204.148.72 with SMTP id o8mr1473893bkv.103.1344620071408; Fri, 10 Aug 2012 10:34:31 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.231.7 with HTTP; Fri, 10 Aug 2012 10:34:01 -0700 (PDT) In-Reply-To: References: <5025228E.5030705@minibofh.org> From: Chris Rees Date: Fri, 10 Aug 2012 18:34:01 +0100 X-Google-Sender-Auth: aQFW9GhO-py0buA982RptuCsBHk Message-ID: To: Kevin Oberman , "b. f." , tor-dev@torproject.org Content-Type: text/plain; charset=ISO-8859-1 Cc: Jordi Espasa Clofent , freebsd-ports@freebsd.org Subject: Re: tcmalloc in Tor FreeBSD port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2012 17:34:36 -0000 Forwarding to tor-dev mailing list; this is their problem. On 10 August 2012 18:15, Kevin Oberman wrote: > On Fri, Aug 10, 2012 at 8:02 AM, Jordi Espasa Clofent > wrote: >> Hi all, >> >> Please, read the follow thread in tor-dev to be in the loop: >> https://lists.torproject.org/pipermail/tor-dev/2012-August/003878.html >> >> I tried to contact the mantainer according to Makefile and Freshports, but I >> didn't receive any answer. So I guess this mail-list is probably the most >> accurate place to ask. > > First, bf is typically pretty active, so he (she?) must be away or you > would have heard from him (her?) He :) > Looks like this broke when the port was converted to use OPTIONSNG > about two months ago. I am not a make wizard or even close to it, but > the options code is clearly not doing what it's supposed to be doing. > You can probably roll the Makefile back to r297464, edit the > DISTVERSION to "DISTVERSION= 0.2.2.37", remove the > "ftp://ftp.fodt.it/pub/mirror/tor/dist/ \" line, keep the rest of the > existing port, and build it. > > If I get a few minutes, I will see if I can figure out why the options > are not working after the change to OPTIONSNG. I have a port htat I > really need to convert to OPTIONSNG, so maybe I'll get that done, too. Brendan's code in the port is perfectly fine. The configure.in is where the problem lies; if test x$tcmalloc = xyes ; then using_custom_malloc=yes fi if test $using_custom_malloc = no ; then AC_CHECK_FUNCS(mallinfo malloc_good_size malloc_usable_size) fi ^^^ this stanza is included before $tcmalloc is set; examine where it is set in configure further down; # Check whether --with-tcmalloc was given. if test "${with_tcmalloc+set}" = set; then : withval=$with_tcmalloc; tcmalloc=yes else tcmalloc=no fi Oops! The result is that using_custom_malloc will never be set to yes, and tcmalloc will probably never be used. Chris