From owner-freebsd-audit Sun Jun 24 19:46:23 2001 Delivered-To: freebsd-audit@freebsd.org Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19]) by hub.freebsd.org (Postfix) with ESMTP id CADDC37B406 for ; Sun, 24 Jun 2001 19:46:04 -0700 (PDT) (envelope-from mike@coffee.q9media.com) Received: (from mike@localhost) by coffee.q9media.com (8.11.2/8.11.2) id f5P2wsU91530; Sun, 24 Jun 2001 22:58:54 -0400 (EDT) (envelope-from mike) Date: Sun, 24 Jun 2001 22:58:54 -0400 (EDT) Message-Id: <200106250258.f5P2wsU91530@coffee.q9media.com> To: audit@FreeBSD.org From: Mike Barcroft Cc: Dag-Erling Smorgrav Subject: Re: src/usr.bin warns patch (also Re: src/usr.sbin warns patch) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG The patch at the end of this message and also available at: http://testbed.q9media.net/freebsd/mega.20010625.patch ...combines the src/usr.bin and src/usr.sbin patches. It also adds WARNS?=2 to src/usr.sbin/jail (which just recently became warning free - thanks Dima). The issue DES brought up has also been resolved, as my includes patch has been committed (thanks again Dima). I believe DES is going to commit this for me; I just wanted to update the list. Best regards, Mike Barcroft ----------------------------------------------------------------------- mega.20010625.patch o Set WARNS?=2 on Makefiles that should have it in src/usr.bin and src/usr.sbin. Index: usr.bin/basename/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/basename/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- usr.bin/basename/Makefile 1998/12/06 22:58:12 1.2 +++ usr.bin/basename/Makefile 2001/06/24 15:45:45 @@ -1,7 +1,7 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= basename -CFLAGS+=-Wall +WARNS?= 2 MLINKS= basename.1 dirname.1 .include Index: usr.bin/biff/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/biff/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- usr.bin/biff/Makefile 1998/12/06 22:58:12 1.2 +++ usr.bin/biff/Makefile 2001/06/24 15:45:46 @@ -1,6 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= biff -CFLAGS+=-Wall +WARNS?= 2 .include Index: usr.bin/cap_mkdb/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/cap_mkdb/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- usr.bin/cap_mkdb/Makefile 1998/12/06 22:58:12 1.2 +++ usr.bin/cap_mkdb/Makefile 2001/06/24 15:45:46 @@ -1,6 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= cap_mkdb -CFLAGS+=-Wall +WARNS?= 2 .include Index: usr.bin/colrm/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/colrm/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- usr.bin/colrm/Makefile 1998/12/06 22:58:18 1.2 +++ usr.bin/colrm/Makefile 2001/06/24 15:45:50 @@ -1,6 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= colrm -CFLAGS+=-Wall +WARNS?= 2 .include Index: usr.bin/dirname/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/dirname/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- usr.bin/dirname/Makefile 1998/12/06 22:58:20 1.2 +++ usr.bin/dirname/Makefile 2001/06/24 15:45:50 @@ -1,7 +1,7 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= dirname -CFLAGS+=-Wall +WARNS?= 2 NOMAN= noman .include Index: usr.bin/env/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/env/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- usr.bin/env/Makefile 1998/12/06 22:58:22 1.2 +++ usr.bin/env/Makefile 2001/06/24 15:45:50 @@ -1,7 +1,7 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= env -CFLAGS+=-Wall +WARNS?= 2 NOMAN= noman .include Index: usr.bin/file2c/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/file2c/Makefile,v retrieving revision 1.5 diff -u -r1.5 Makefile --- usr.bin/file2c/Makefile 2001/03/27 10:51:43 1.5 +++ usr.bin/file2c/Makefile 2001/06/24 15:45:52 @@ -1,5 +1,6 @@ # $FreeBSD: src/usr.bin/file2c/Makefile,v 1.5 2001/03/27 10:51:43 ru Exp $ PROG= file2c +WARNS?= 2 .include Index: usr.bin/fold/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/fold/Makefile,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Makefile --- usr.bin/fold/Makefile 1994/05/27 12:31:17 1.1.1.1 +++ usr.bin/fold/Makefile 2001/06/24 15:45:52 @@ -1,5 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= fold +WARNS?= 2 .include Index: usr.bin/from/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/from/Makefile,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Makefile --- usr.bin/from/Makefile 1994/05/27 12:31:22 1.1.1.1 +++ usr.bin/from/Makefile 2001/06/24 15:45:52 @@ -1,5 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= from +WARNS?= 2 .include Index: usr.bin/fsync/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/fsync/Makefile,v retrieving revision 1.2 diff -u -r1.2 Makefile --- usr.bin/fsync/Makefile 2000/07/19 08:44:26 1.2 +++ usr.bin/fsync/Makefile 2001/06/24 15:45:52 @@ -1,5 +1,6 @@ # $FreeBSD: src/usr.bin/fsync/Makefile,v 1.2 2000/07/19 08:44:26 ps Exp $ PROG= fsync +WARNS?= 2 .include Index: usr.bin/gencat/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/gencat/Makefile,v retrieving revision 1.5 diff -u -r1.5 Makefile --- usr.bin/gencat/Makefile 1999/08/28 01:01:40 1.5 +++ usr.bin/gencat/Makefile 2001/06/24 15:45:52 @@ -2,6 +2,7 @@ PROG= gencat SRCS= gencat.c genlib.c +WARNS?= 2 CFLAGS+= -I${.CURDIR}/../../lib/libc/nls Index: usr.sbin/jail/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/jail/Makefile,v retrieving revision 1.6 diff -u -r1.6 Makefile --- usr.sbin/jail/Makefile 2001/03/26 14:40:27 1.6 +++ usr.sbin/jail/Makefile 2001/06/24 04:42:13 @@ -1,6 +1,7 @@ # $FreeBSD: src/usr.sbin/jail/Makefile,v 1.6 2001/03/26 14:40:27 ru Exp $ PROG= jail +WARNS?= 2 MAN= jail.8 .include Index: usr.bin/key/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/key/Makefile,v retrieving revision 1.5 diff -u -r1.5 Makefile --- usr.bin/key/Makefile 2001/03/27 10:51:47 1.5 +++ usr.bin/key/Makefile 2001/06/24 15:45:53 @@ -3,6 +3,7 @@ PROG= key SRCS= skey.c +WARNS?= 2 CFLAGS+= -D_SKEY_INTERNAL Index: usr.bin/keyinfo/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/keyinfo/Makefile,v retrieving revision 1.8 diff -u -r1.8 Makefile --- usr.bin/keyinfo/Makefile 2000/11/28 07:24:15 1.8 +++ usr.bin/keyinfo/Makefile 2001/06/24 15:45:53 @@ -2,7 +2,7 @@ # $FreeBSD: src/usr.bin/keyinfo/Makefile,v 1.8 2000/11/28 07:24:15 marcel Exp $ PROG= keyinfo -CFLAGS+=-Wall +WARNS?= 2 DPADD= ${LIBSKEY} ${LIBCRYPT} ${LIBMD} LDADD= -lskey -lcrypt -lmd BINMODE=4555 Index: usr.bin/keyinit/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/keyinit/Makefile,v retrieving revision 1.7 diff -u -r1.7 Makefile --- usr.bin/keyinit/Makefile 2001/03/27 10:51:47 1.7 +++ usr.bin/keyinit/Makefile 2001/06/24 15:45:53 @@ -3,6 +3,7 @@ PROG= keyinit SRCS= skeyinit.c +WARNS?= 2 CFLAGS+= -D_SKEY_INTERNAL Index: usr.bin/keylogout/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/keylogout/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- usr.bin/keylogout/Makefile 1999/08/28 01:02:28 1.3 +++ usr.bin/keylogout/Makefile 2001/06/24 15:45:53 @@ -1,6 +1,7 @@ # $FreeBSD: src/usr.bin/keylogout/Makefile,v 1.3 1999/08/28 01:02:28 peter Exp $ PROG= keylogout +WARNS?= 2 DPADD= ${LIBRPCSVC} LDADD= -lrpcsvc Index: usr.bin/leave/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/leave/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- usr.bin/leave/Makefile 1999/08/28 01:02:45 1.3 +++ usr.bin/leave/Makefile 2001/06/24 15:45:56 @@ -2,6 +2,6 @@ # $FreeBSD: src/usr.bin/leave/Makefile,v 1.3 1999/08/28 01:02:45 peter Exp $ PROG= leave -CFLAGS+=-Wall +WARNS?= 2 .include Index: usr.bin/mesg/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/mesg/Makefile,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Makefile --- usr.bin/mesg/Makefile 1994/05/27 12:30:44 1.1.1.1 +++ usr.bin/mesg/Makefile 2001/06/24 15:46:01 @@ -1,5 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= mesg +WARNS?= 2 .include Index: usr.bin/mkfifo/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/mkfifo/Makefile,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Makefile --- usr.bin/mkfifo/Makefile 1994/05/27 12:32:19 1.1.1.1 +++ usr.bin/mkfifo/Makefile 2001/06/24 15:46:01 @@ -1,5 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= mkfifo +WARNS?= 2 .include Index: usr.bin/strip/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/strip/Makefile,v retrieving revision 1.11 diff -u -r1.11 Makefile --- usr.bin/strip/Makefile 2001/03/27 10:52:15 1.11 +++ usr.bin/strip/Makefile 2001/06/24 15:46:06 @@ -2,6 +2,7 @@ # $FreeBSD: src/usr.bin/strip/Makefile,v 1.11 2001/03/27 10:52:15 ru Exp $ PROG= strip +WARNS?= 2 MAN= strip.1aout BINDIR= /usr/libexec/aout CLEANFILES += maybe_stripped Index: usr.bin/truncate/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/truncate/Makefile,v retrieving revision 1.1 diff -u -r1.1 Makefile --- usr.bin/truncate/Makefile 2000/07/18 17:03:58 1.1 +++ usr.bin/truncate/Makefile 2001/06/24 15:46:07 @@ -1,5 +1,6 @@ # $FreeBSD: src/usr.bin/truncate/Makefile,v 1.1 2000/07/18 17:03:58 sheldonh Exp $ PROG= truncate +WARNS?= 2 .include Index: usr.bin/unexpand/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/unexpand/Makefile,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Makefile --- usr.bin/unexpand/Makefile 1994/05/27 12:33:15 1.1.1.1 +++ usr.bin/unexpand/Makefile 2001/06/24 15:46:07 @@ -1,6 +1,7 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= unexpand +WARNS?= 2 NOMAN= noman .include Index: usr.bin/what/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/what/Makefile,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Makefile --- usr.bin/what/Makefile 1994/05/27 12:33:28 1.1.1.1 +++ usr.bin/what/Makefile 2001/06/24 15:46:13 @@ -1,5 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= what +WARNS?= 2 .include Index: usr.bin/yes/Makefile =================================================================== RCS file: /home/ncvs/src/usr.bin/yes/Makefile,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 Makefile --- usr.bin/yes/Makefile 1994/05/27 12:33:42 1.1.1.1 +++ usr.bin/yes/Makefile 2001/06/24 15:46:14 @@ -1,5 +1,6 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 PROG= yes +WARNS?= 2 .include Index: usr.sbin/accton/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/accton/Makefile,v retrieving revision 1.4 diff -u -r1.4 Makefile --- usr.sbin/accton/Makefile 2001/03/26 14:39:16 1.4 +++ usr.sbin/accton/Makefile 2001/06/24 15:46:15 @@ -2,6 +2,7 @@ # $FreeBSD: src/usr.sbin/accton/Makefile,v 1.4 2001/03/26 14:39:16 ru Exp $ PROG= accton +WARNS?= 2 MAN= accton.8 .include Index: usr.sbin/dev_mkdb/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/dev_mkdb/Makefile,v retrieving revision 1.4 diff -u -r1.4 Makefile --- usr.sbin/dev_mkdb/Makefile 2001/03/26 14:39:50 1.4 +++ usr.sbin/dev_mkdb/Makefile 2001/06/24 15:46:23 @@ -2,6 +2,7 @@ # $FreeBSD: src/usr.sbin/dev_mkdb/Makefile,v 1.4 2001/03/26 14:39:50 ru Exp $ PROG= dev_mkdb +WARNS?= 2 MAN= dev_mkdb.8 .include Index: usr.sbin/digictl/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/digictl/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- usr.sbin/digictl/Makefile 2001/05/17 01:42:52 1.3 +++ usr.sbin/digictl/Makefile 2001/06/24 15:46:23 @@ -1,6 +1,7 @@ # $FreeBSD: src/usr.sbin/digictl/Makefile,v 1.3 2001/05/17 01:42:52 brian Exp $ PROG= digictl +WARNS?= 2 MAN= digictl.8 .include Index: usr.sbin/lastlogin/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/lastlogin/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- usr.sbin/lastlogin/Makefile 2001/03/26 14:40:33 1.3 +++ usr.sbin/lastlogin/Makefile 2001/06/24 15:46:26 @@ -1,7 +1,7 @@ # $FreeBSD: src/usr.sbin/lastlogin/Makefile,v 1.3 2001/03/26 14:40:33 ru Exp $ PROG= lastlogin +WARNS?= 2 MAN= lastlogin.8 -CFLAGS+=-Wall .include Index: usr.sbin/procctl/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/procctl/Makefile,v retrieving revision 1.6 diff -u -r1.6 Makefile --- usr.sbin/procctl/Makefile 2001/03/26 14:41:30 1.6 +++ usr.sbin/procctl/Makefile 2001/06/24 15:46:42 @@ -1,6 +1,7 @@ # $FreeBSD: src/usr.sbin/procctl/Makefile,v 1.6 2001/03/26 14:41:30 ru Exp $ PROG= procctl +WARNS?= 2 MAN= procctl.8 .include Index: usr.sbin/rip6query/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/rip6query/Makefile,v retrieving revision 1.4 diff -u -r1.4 Makefile --- usr.sbin/rip6query/Makefile 2001/03/26 14:41:41 1.4 +++ usr.sbin/rip6query/Makefile 2001/06/24 15:46:42 @@ -3,6 +3,7 @@ # $FreeBSD: src/usr.sbin/rip6query/Makefile,v 1.4 2001/03/26 14:41:41 ru Exp $ PROG= rip6query +WARNS?= 2 MAN= rip6query.8 CFLAGS+=-DINET6 -I${.CURDIR}/../route6d Index: usr.sbin/usbdevs/Makefile =================================================================== RCS file: /home/ncvs/src/usr.sbin/usbdevs/Makefile,v retrieving revision 1.8 diff -u -r1.8 Makefile --- usr.sbin/usbdevs/Makefile 2001/05/18 13:41:42 1.8 +++ usr.sbin/usbdevs/Makefile 2001/06/24 15:46:47 @@ -2,6 +2,7 @@ # FreeBSD $FreeBSD: src/usr.sbin/usbdevs/Makefile,v 1.8 2001/05/18 13:41:42 ru Exp $ PROG= usbdevs +WARNS?= 2 MAN= usbdevs.8 .include To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message