Date: Tue, 4 Dec 2018 09:38:23 +0100 From: Oliver Pinter <oliver.pinter@hardenedbsd.org> To: Yuri Pankov <yuripv@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r341446 - head/release/amd64 Message-ID: <CAPQ4ffuV6hCftc9sXO=VhMriCWCajrPkVjmpBVgxS=34-zxQfQ@mail.gmail.com> In-Reply-To: <7fd4cc67-52df-56e1-faa9-281d4ddf57e2@FreeBSD.org> References: <201812032231.wB3MVvaD060931@repo.freebsd.org> <CAPQ4ffsc8ESKB27H0L81cUMvw==pGGmRZ5LyfHOZD-C=j53-jA@mail.gmail.com> <7fd4cc67-52df-56e1-faa9-281d4ddf57e2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, December 4, 2018, Yuri Pankov <yuripv@freebsd.org> wrote: > Oliver Pinter wrote: > > > > > > On Monday, December 3, 2018, Yuri Pankov <yuripv@freebsd.org > > <mailto:yuripv@freebsd.org>> wrote: > > > > Author: yuripv > > Date: Mon Dec 3 22:31:57 2018 > > New Revision: 341446 > > URL: https://svnweb.freebsd.org/changeset/base/341446 > > <https://svnweb.freebsd.org/changeset/base/341446>; > > > > Log: > > mkisoimages.sh: don't use -p flag when copying loader.efi to > msdosfs. > > > > This fixes 'cdrom' target in the case when world was built by user, > > and not root. > > > > Reviewed by: imp > > Differential revision: https://reviews.freebsd.org/D18414 > > <https://reviews.freebsd.org/D18414>; > > > > > > This was a known issue > > : https://lists.freebsd.org/pipermail/svn-src-head/2018- > November/119689.html > > Sorry, I missed that. No problem. Ed was directly CCd and notified on IRC. > > Looking at the HBSD change, does chmod step have any significance? It just ensures the correct file permissions. > > Modified: > > head/release/amd64/mkisoimages.sh > > > > Modified: head/release/amd64/mkisoimages.sh > > ============================================================ > ================== > > --- head/release/amd64/mkisoimages.sh Mon Dec 3 22:09:23 2018 > > (r341445) > > +++ head/release/amd64/mkisoimages.sh Mon Dec 3 22:31:57 2018 > > (r341446) > > @@ -49,7 +49,7 @@ if [ "$1" = "-b" ]; then > > mkdir efi > > mount -t msdosfs /dev/$device efi > > mkdir -p efi/efi/boot > > - cp -p "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi > > + cp "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi > > umount efi > > rmdir efi > > mdconfig -d -u $device > > _______________________________________________ > > svn-src-head@freebsd.org <mailto:svn-src-head@freebsd.org> mailing > list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > <https://lists.freebsd.org/mailman/listinfo/svn-src-head>; > > To unsubscribe, send any mail to > > "svn-src-head-unsubscribe@freebsd.org > > <mailto:svn-src-head-unsubscribe@freebsd.org>" > > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffuV6hCftc9sXO=VhMriCWCajrPkVjmpBVgxS=34-zxQfQ>