From owner-freebsd-ports-bugs@freebsd.org Tue Aug 15 15:36:36 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F306DDB673 for ; Tue, 15 Aug 2017 15:36:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4A574477 for ; Tue, 15 Aug 2017 15:36:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7FFaZAX021214 for ; Tue, 15 Aug 2017 15:36:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210170] www/uwsgi: Add Emperor mode support Date: Tue, 15 Aug 2017 15:36:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ultima@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2017 15:36:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210170 --- Comment #11 from Richard Gallamore --- (In reply to David Wahlund from comment #10) Few things, * Pretty sure adding www to group uwsgi would require user interaction, or = am I wrong? Maybe best to leave at least the group to www for socket. * All the /usr/local entries should be %%PREFIX%% * Why was command_args was removed and changed to uwsgi_flags? This should probably be changed back to command_args after the if checkyesno uwsgi_empe= ror and add uwsgi_flags to it. _flags is usually not modified in the rc.d scrip= t, but sometimes it is necessary. * The beginning quote should start the defining variable. Pretty sure that = if a space were added at the end of uwsgi_configfile, this would drop the rest of the line. Same with the other variables at the end of the defining variable. other than that it looks good to me. Thanks for working on this David. --=20 You are receiving this mail because: You are the assignee for the bug.=