Date: Sun, 17 Jun 2007 00:14:45 -0500 From: Alan Cox <alc@cs.rice.edu> To: Matt Jacob <mjacob@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_mmap.c Message-ID: <4674C345.5010207@cs.rice.edu> In-Reply-To: <200706170417.l5H4Hn29025615@repoman.freebsd.org> References: <200706170417.l5H4Hn29025615@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Matt Jacob wrote:
>mjacob 2007-06-17 04:17:49 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/vm vm_mmap.c
> Log:
> Make sure object is NULL- there is a possible case where you could
> fall through to it being used w/o being set. Put a break in the default
> case.
>
> Revision Changes Path
> 1.211 +2 -1 src/sys/vm/vm_mmap.c
>
>
Actually, no. handle_type is OBJT_DEFAULT only if flags has MAP_ANON
set. So, object was, in fact, being initialized to NULL a few lines
after the switch:
if (flags & MAP_ANON) {
object = NULL;
In any case, I'm happy to see the warnings eliminated.
Regards,
Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4674C345.5010207>