From owner-cvs-src@FreeBSD.ORG Sat Dec 17 19:45:16 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC02D16A420; Sat, 17 Dec 2005 19:45:16 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3F5943D76; Sat, 17 Dec 2005 19:45:15 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 4018225 for multiple; Sat, 17 Dec 2005 14:43:16 -0500 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jBHJj6uW000370; Sat, 17 Dec 2005 14:45:08 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Nate Lawson Date: Sat, 17 Dec 2005 14:45:02 -0500 User-Agent: KMail/1.8.3 References: <200512170357.jBH3vAhh030893@repoman.freebsd.org> In-Reply-To: <200512170357.jBH3vAhh030893@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200512171445.04475.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV 0.87.1/1211/Fri Dec 16 17:51:35 2005 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys ktr.h src/sys/kern kern_clock.c kern_switch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2005 19:45:17 -0000 On Friday 16 December 2005 10:57 pm, Nate Lawson wrote: > njl 2005-12-17 03:57:10 UTC > > FreeBSD src repository > > Modified files: > sys/sys ktr.h > sys/kern kern_clock.c kern_switch.c > Log: > Clean up unused or poorly utilized KTR values. Remove KTR_FS, KTR_KGDB, > and KTR_IO as they were never used. Remove KTR_CLK since it was only > used for hardclock firing and use KTR_INTR there instead. Remove > KTR_CRITICAL since it was only used for crit enter/exit and use > KTR_CONTENTION instead. Actually, I thought I had mentioned that KTR_CRITICAL should stay as it is= =20 (well, and the larger thought about doing away with the entire bitmask=20 concept which no one responded to). critical_enter/exit are not related in= =20 the least to KTR_CONTENTION which is used for MUTEX_PROFILING, nor do they= =20 have anything at all to do with contention of any sort. If you must stick= =20 them somewhere, put them in KTR_SCHED instead. I think scottl@ recently=20 added support to schedgraph for those traces anyway (though I'm not sure if= =20 they are in his local tree or CVS). The hardclock trace can probably just be axed entirely as it isn't all that= =20 useful. =2D-=20 John Baldwin =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org