From nobody Wed Oct 2 12:47:49 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XJZNC2ddLz5YTnq for ; Wed, 02 Oct 2024 12:47:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XJZNC1BR2z4bKP for ; Wed, 2 Oct 2024 12:47:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727873275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vFDdtIi4WP3kvlcI1315Qh5a9B7pc64206Gx015E7bw=; b=KDu3I90AQyAFaWHVfZCZmfVDVlwp04qEUxe4cABo9vmhI4NJSlU3e7pB8tavWkGGRU1RLj mqQle59bAvs398EV6o7GSS9fCCJOX6Kqs5LNaAXMhusZa17Z1R4iVi2LhP8pUq8/lM4hO2 1iDLZedjVNMmTSOlEf5gewksYBPqzjKgaX2C/dslOhbiQnC5Qt6/B5rPOdtj4cr4IoyW/k 7cXLy3bwa7hker9VY6XO8rqkcG1BRPcYQS8iFg1Orgc5oF/5zerqVRBa3riN+HOVIKDiIi URRFDpB5fPhmu/GV2EwYbcv22UpeBOmLIeC2yWAXH9ZDXfbzydFp3GPHkdUqGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727873275; a=rsa-sha256; cv=none; b=mwdm67aNdmzkfdsAfo3zW3ReLmQxHuhpVkVOMqSnEpknwjW5Jwq6F/q3tTxJ6Crrsf0/Jf r13eXmSupPGtx4+SkYcuu4AQhRtqw3J7HPQr9hhM8TgAC1fAbZIiFZE/+IiTPCpXQ5NPLz bqAdZJh11Fyqa3cgkxKbsf5+uscEp2lJWkhrXnCTFgEL0p/WWao2IM0icZJeksao78Wqb9 cvjuPHDhPhY+gqYQ3kVRDlYYIYkn854kThscuHEh63Ry8Jr3SLEMvKKrR4zyxmopMpUSKQ rawmR/MccU2fKog2a2/tPf/pxPyLbgrpq9OW0RAgwPnOhsqnii2nXXSBC70Jow== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XJZNC0p70z1Ly2 for ; Wed, 2 Oct 2024 12:47:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 492Clstq017757 for ; Wed, 2 Oct 2024 12:47:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 492ClscD017754 for ports-bugs@FreeBSD.org; Wed, 2 Oct 2024 12:47:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281817] net/samba416: fix rl_completion_func_t detection and usage Date: Wed, 02 Oct 2024 12:47:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: samba@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281817 Bug ID: 281817 Summary: net/samba416: fix rl_completion_func_t detection and usage Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: samba@FreeBSD.org Reporter: dim@FreeBSD.org Flags: maintainer-feedback?(samba@FreeBSD.org) Assignee: samba@FreeBSD.org net/samba416: fix rl_completion_func_t detection and usage After a recent devel/readline update, net/samba416 fails to compile with clang 19, resulting in errors similar to: ../../libcli/smbreadline/smbreadline.c:139:38: warning: 'CPPFunction' is deprecated [-Wdeprecated-declarations] 139 | rl_attempted_completion_function =3D RL_COMPLETIO= N_CAST completion_fn; | ^ ../../lib/replace/system/readline.h:50:31: note: expanded from macro 'RL_COMPLETION_CAST' 50 | # define RL_COMPLETION_CAST (CPPFunction *) | ^ /usr/local/include/readline/rltypedefs.h:38:50: note: 'CPPFunction' has b= een explicitly marked deprecated here 38 | typedef char **CPPFunction (void) __attribute__((deprecated)); | ^ ../../libcli/smbreadline/smbreadline.c:139:36: error: incompatible functi= on pointer types assigning to 'rl_completion_func_t *' (aka 'char **(*)(const = char *, int, int)') from 'CPPFunction *' (aka 'char **(*)(void)') [-Wincompatible-function-pointer-types] 139 | rl_attempted_completion_function =3D RL_COMPLETIO= N_CAST completion_fn; | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ There are two reasons: samba checks for `rl_completion_t`, while the actual readline type is `rl_completion_func_t`, and samba's wrapper `readline.h` header prefers the `CPPFunction` type which is deprecated, while it should use `rl_completion_func_t` instead. Fix the `wscript_configure` check to detect `rl_completion_func_t`, and reverse the `HAVE_RL_COMPLETION_T` and `HAVE_CPPFUNCTION` checks in the wrapper header. --=20 You are receiving this mail because: You are the assignee for the bug.=