From owner-freebsd-bugs  Mon Jul 31 13:30: 9 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 96AD037B7A3
	for <freebsd-bugs@FreeBSD.org>; Mon, 31 Jul 2000 13:30:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id NAA83594;
	Mon, 31 Jul 2000 13:30:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103])
	by hub.freebsd.org (Postfix) with ESMTP id 8F70C37BCD0
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Jul 2000 13:25:19 -0700 (PDT)
	(envelope-from k@numeri.campus.luth.se)
Received: (from k@localhost)
	by numeri.campus.luth.se (8.9.3/8.9.3) id WAA04304;
	Mon, 31 Jul 2000 22:25:41 +0200 (CEST)
	(envelope-from k)
Message-Id: <200007312025.WAA04304@numeri.campus.luth.se>
Date: Mon, 31 Jul 2000 22:25:41 +0200 (CEST)
From: Johan Karlsson <k@numeri.campus.luth.se>
Reply-To: k@numeri.campus.luth.se
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: misc/20326: [PATCH] installkernel fails if DESTDIR is empty
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         20326
>Category:       misc
>Synopsis:       [PATCH] installkernel fails if DESTDIR is empty
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 31 13:30:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Johan Karlsson
>Release:        FreeBSD 4.1-STABLE i386
>Organization:
>Environment:

src/Makefile.inc1:
     $FreeBSD: src/Makefile.inc1,v 1.163 2000/07/23 21:30:35 marcel Exp $

>Description:

	When building/installing world and a kernel by:

	# make buildworld
	# make buildkernel
	# make DESTDIR=foo installkernel
	# make DESTDIR=foo installworld
	
	the installkernel will fail if DESTDIR is an empty directory.

	Since this is the recomended way by src/UPDATING one would 
	expect this to work.

>How-To-Repeat:

	# make buildworld
	# make buildkernel
	# make DESTDIR=path_to_empty_dir installkernel

>Fix:
Index: Makefile.inc1
===================================================================
RCS file: /host/queeg.ludd/FreeBSD-mirror/ncvs/src/Makefile.inc1,v
retrieving revision 1.163
diff -u -r1.163 Makefile.inc1
--- Makefile.inc1	2000/07/23 21:30:35	1.163
+++ Makefile.inc1	2000/07/31 18:55:06
@@ -415,6 +415,9 @@
 # Install the kernel defined by INSTALLKERNEL
 #
 installkernel:
+	cd ${.CURDIR}; \
+		${CROSSENV} MACHINE=${MACHINE} \
+		    ${MAKE} -f Makefile.inc1 hierarchy
 	cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
 		${CROSSENV} MACHINE=${MACHINE} KERNEL=kernel ${MAKE} install
 



>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message