From owner-freebsd-current@freebsd.org Sun Jun 3 13:20:26 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA410F7CCE1 for ; Sun, 3 Jun 2018 13:20:25 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86B5D84B9F; Sun, 3 Jun 2018 13:20:25 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-qk0-x242.google.com with SMTP id d130-v6so17869973qkc.2; Sun, 03 Jun 2018 06:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fY4BTTFswERKq9rX+5Y0B/xjby0Y+zXPuLsxdW4Tgas=; b=uUTi5rsbCoRAv25pzDgtubGTlf/hVaAiczxzaKiPgtfP0KBmNYcniTG8j+1ZSrkt0V B0GQhSJPpG7gPirRNypousnqyU2Rs37EDCQMnCBBLoSHccr+YQnATPOiQ/j2efhwvtrQ JN28sX1FXGAk1d7DSy274nOnqI2Ww/SzXXio4n2x+uYRtQWJS8VB96VRR2y+TgI8gq1G /mbqSWzcJz3bput1AuPbGxfRZu3rNnYt7Lv2f0Gn4tBlSF7MkeagEq354dI0MnEu9X1O l11M6GtCRxy5b8MH6+NCNdz83MyTU1TSYJveNA1VCaIQ/OLNNN1EQRe+LqLxRvNhgsr4 gt9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fY4BTTFswERKq9rX+5Y0B/xjby0Y+zXPuLsxdW4Tgas=; b=FquTFZke/jcSwhQhcBdsgu6n2Y/jebp0V3lht7SeWWaheUKQ2/cmKp4W1aN5a9Zt4e 8o/aHDwU9zCdUb9WQMB6w5NZi/TPkcIO+Rdl+tgVuLAhvT3N3P9FUh6xyFz561xDSODX T3oeMyihrxcSB+2u25MpFTmek7FqFw9CKpoNIWfDOnH5oHil/wLz3o/kQIK4h8vBiVyD wm2h/uOK7d+Lnd5OTH9Hn7YDblNyoziexSkoGpxi4RG1OgriCqHeem+nXvnhO0uXJH+k PxXFZQWjeY3sTK8TrnJkd215lXhk4hOB0SdaRnsuSQM62fbJFRbBaprfWFpggRhpc5/9 D49w== X-Gm-Message-State: APt69E385oRRGV9J0cBJhmBgZhiKXAOWW6qvwtxFn5dYEwd91NVT5mZZ zaUU0wOkCmFLLHECfcndvNu1LUGPa5DmSIWEzBk= X-Google-Smtp-Source: ADUXVKKo2BzUUGgXoun1AhXp52CgovkyzYXvDxStswp3yE0Y1f1YIcWQG9MUm58XhisTfaIYDdiIAG5/pLAvuAFQ5+I= X-Received: by 2002:a37:9342:: with SMTP id v63-v6mr16886369qkd.40.1528032025155; Sun, 03 Jun 2018 06:20:25 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac8:1c4e:0:0:0:0:0 with HTTP; Sun, 3 Jun 2018 06:20:24 -0700 (PDT) In-Reply-To: <20180603214222.953748e1eb7a0b39e11214ae@dec.sakura.ne.jp> References: <83fec8d8-699f-e86c-9884-9d8698a86a91@gmail.com> <20180603214222.953748e1eb7a0b39e11214ae@dec.sakura.ne.jp> From: Mateusz Guzik Date: Sun, 3 Jun 2018 15:20:24 +0200 Message-ID: Subject: Re: Error build nvidia-driver with r334555 To: junchoon@dec.sakura.ne.jp Cc: FreeBSD Current , alexvpetrov@gmail.com, Mateusz Guzik , Alexey Dokuchaev , ler@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 13:20:26 -0000 On Sun, Jun 3, 2018 at 2:42 PM, Tomoaki AOKI wrote: > This is caused by r334533 and/or r334534 (memset-related changes). > sysutils/lsof is also affected. > > You should revert r334533 and r334534 temporarily until nvidia-driver > support this change. > > CC'ing the revision author and maintainers of both ports. > > Support in what sense? The error message clearly indicates a bug in the driver (also trivially fixable). Is there a problem adding a patch to files/? diff -ru src.orig/nvidia/nvidia_subr.c src/nvidia/nvidia_subr.c --- src.orig/nvidia/nvidia_subr.c 2018-06-03 13:19:56.490480000 +0000 +++ src/nvidia/nvidia_subr.c 2018-06-03 13:21:15.289344000 +0000 @@ -364,7 +364,7 @@ } ci = args; - memset(ci, 0, sizeof(ci)); + memset(ci, 0, sizeof(*ci)); for (i = 0; i < NV_MAX_DEVICES; i++) { sc = devclass_get_softc(nvidia_devclass, i); As for lsof: --- dlsof.h.orig 2018-06-03 13:16:14.712701000 +0000 +++ dlsof.h 2018-06-03 13:17:15.042655000 +0000 @@ -489,6 +489,12 @@ # endif /* FREEBSDV>=2020 */ #undef bzero /* avoid _KERNEL conflict */ +#undef bcmp +#undef bcopy +#undef memcmp +#undef memmove +#undef memcpy +#undef memset #include -- Mateusz Guzik