From owner-svn-src-head@freebsd.org Sun Apr 10 11:13:51 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35CF1AE2012 for ; Sun, 10 Apr 2016 11:13:51 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CAE8F15FD for ; Sun, 10 Apr 2016 11:13:50 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-wm0-x235.google.com with SMTP id 191so57177707wmq.0 for ; Sun, 10 Apr 2016 04:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=AnLBP5tNzFMQYlXhbLNuTiRV/u8VfcaPj20sadSUuv8=; b=0uDlARO/o+YM2qzpKDc84MwzLNXCXbz8IA92ozngALqOAzw7veh5y3JyAyNbDsCogP jJihZEM13YBbRXm6dQWn/rod/Ix5737oTvczTBds0SSm8U7RJkjDc9XeBlYh7Npn1bEr wNE9FOk3NgJ73Vhaf5/zgkXeZ+4B/cbZprnqNISuuYCrWWD4jRlvCq47kxNZgvY9ZBAW nJtWAPhEv+rgUvmHBtGcnWm8HEHIk4xr+f21oJ4ZfOrADDHlMCLRFnStWvkMflL8WikA TUUniPP5i1BsCy+3C7DX298c/4KMoHJ72+c+Y5OMvXB6weVfGa1+BaBMnyFkxpzLy080 3OOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=AnLBP5tNzFMQYlXhbLNuTiRV/u8VfcaPj20sadSUuv8=; b=V3DD0cwBIoY0odKXxq3xtGJuDWPhKnIa8LpjftgJ460/FcEL+adkzNOz+Ip2ExKcS0 A4RmkdHINX2awzFM8GfBvs8WT5bAuMlK/B1UtjUctXrlxYgDcBqi3Z8A5E9gpv1MoUbH Xh8+VGLDrOIFiYNATGabH81KozRnSz1LTE9DZID1beLyaGzqlLjndLUY0WzrFXCxOa+r YTNS8rxwW1S9Dzpz8ry7gsHE2zXFEJilE6yf4ie7lPlNXIpwxQBDliIlIBah82wLGsSN KOJuKxnziUQ4eKBllNb/+6xM7ff7/98uMa/aCcjcDAidMAS6KFCxJ2IafgniE2mI1Jml qi9A== X-Gm-Message-State: AD7BkJIKCOAzFcFBKUNqOvi3VkMn7gonYjYGpqWLss4AMO0gaPVpNkl5Dti0M65bLV44RNFw X-Received: by 10.194.61.19 with SMTP id l19mr18499515wjr.4.1460286828301; Sun, 10 Apr 2016 04:13:48 -0700 (PDT) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id j18sm11925806wmd.2.2016.04.10.04.13.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 10 Apr 2016 04:13:47 -0700 (PDT) Subject: Re: svn commit: r297762 - head/sys/dev/ichiic To: John Baldwin References: <201604092018.u39KIYf3096159@repo.freebsd.org> <57096645.5060105@multiplay.co.uk> <1865392.rtXenzib4K@ralph.baldwin.cx> Cc: svn-src-head@freebsd.org From: Steven Hartland Message-ID: <570A356E.5090506@multiplay.co.uk> Date: Sun, 10 Apr 2016 12:13:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1865392.rtXenzib4K@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Apr 2016 11:13:51 -0000 On 09/04/2016 22:00, John Baldwin wrote: > On Saturday, April 09, 2016 09:29:57 PM Steven Hartland wrote: >> Hi John, it would be nice if the commit message clarified why the change >> was made, as well as what was changed. This would allow others like >> myself to learn about the reasons for changes like this, which aren't >> self explanatory. > Sleeping with a timeout doesn't (currently) work during the initial device > time probe. All sleep requests used to just return immediately without any > delay. I recently changed it so that infinite sleeps (no timeout) now work > in preparation for ongoing work to start APs earlier during the boot. > However, we still can't manage timeouts until we have timers and interrupts > from timers, so sleeps with timeouts will now panic (instead of just > returning instantly which the code here probably did not expect). The > assertion highlighted that this driver was using a tight spin loop during > boot-time attach instead of polling the device periodically (as the author > probably thought they were doing). > Thanks for the explanation John, most appreciated :) Regards Steve