Date: Sun, 14 Nov 2010 21:55:12 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Fix lib/libpam's include of sys/time.h Message-ID: <AANLkTi=BYVFJQ4F5%2B_9=At2%2Bxh-MVxjkxsoquzGU8MzQ@mail.gmail.com> In-Reply-To: <AANLkTi=j_To50_cTV8vPxbNuOCarmdbuASue7dbXp5=g@mail.gmail.com> References: <AANLkTi=j_To50_cTV8vPxbNuOCarmdbuASue7dbXp5=g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--001636eefd2a6543a0049511152a
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On Sun, Nov 14, 2010 at 9:14 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
> =A0 =A0libpam uses sys/time.h to pick up ctime, but it's actually defined
> in time.h according to POSIX and the ctime manpage.
> =A0 =A0If someone could help review and commit this patch, it would be
> much appreciated. This is part of a much larger change to fix
> namespace pollution with time.h in sys/time.h.
Sorry... missed the gettimeofday requirement in the lib. The
library fully compiles with this patch (where sys/time.h isn't
removed). This is POSIX compliant.
Thanks,
-Garrett
--001636eefd2a6543a0049511152a
Content-Type: text/x-patch; charset=US-ASCII;
name="lib-libpam-use-time-dot-h.patch"
Content-Disposition: attachment; filename="lib-libpam-use-time-dot-h.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ggixwadn1
SW5kZXg6IC91c3Ivc3JjL2xpYi9saWJwYW0vbW9kdWxlcy9wYW1fdW5peC9wYW1fdW5peC5jCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIC91c3Ivc3JjL2xpYi9saWJwYW0vbW9kdWxlcy9wYW1fdW5peC9wYW1fdW5p
eC5jCShyZXZpc2lvbiAyMTUzMzMpCisrKyAvdXNyL3NyYy9saWIvbGlicGFtL21vZHVsZXMvcGFt
X3VuaXgvcGFtX3VuaXguYwkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQAogI2luY2x1
ZGUgPHN0cmluZy5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3lzbG9nLmg+Cisj
aW5jbHVkZSA8dGltZS5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgogCiAjaW5jbHVkZSA8bGlidXRp
bC5oPgo=
--001636eefd2a6543a0049511152a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=BYVFJQ4F5%2B_9=At2%2Bxh-MVxjkxsoquzGU8MzQ>