From owner-freebsd-current Fri Apr 19 17:28:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by hub.freebsd.org (Postfix) with ESMTP id 6E81E37B404 for ; Fri, 19 Apr 2002 17:28:34 -0700 (PDT) Received: from hades.hell.gr (patr530-a030.otenet.gr [212.205.215.30]) by mailsrv.otenet.gr (8.12.2/8.12.2) with ESMTP id g3K0SMX6006756; Sat, 20 Apr 2002 03:28:23 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.2/8.12.2) with ESMTP id g3K0SLNl002621; Sat, 20 Apr 2002 03:28:21 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Received: (from charon@localhost) by hades.hell.gr (8.12.2/8.12.2/Submit) id g3K0SI51002620; Sat, 20 Apr 2002 03:28:18 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Date: Sat, 20 Apr 2002 03:28:18 +0300 From: Giorgos Keramidas To: Chad David Cc: current@FreeBSD.org Subject: Re: savecore Message-ID: <20020420002817.GD1464@hades.hell.gr> References: <20020419003134.A54078@colnta.acns.ab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020419003134.A54078@colnta.acns.ab.ca> User-Agent: Mutt/1.3.28i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2002-04-19 00:31, Chad David wrote: > Any comments / objections to these patches to savecore and friends? Since you asked ... :) > Index: savecore.8 > =================================================================== > +The > +.Nm savecore You can safely remove "savecore" from the .Nm arguments, since the macro will add it when given no arguments. (This occurs in several places below, too.) > +Print additional debugging information, including the details of the dump > +header to stdout. The following sounds a tiny bit better: +Print additional debugging information to standard output, +including the details of the dump header. > +The > +.Nm savecore > +command attempts to verify that a core image is valid by verifying it's > +header (magic number and version etc.). "its header". No apostrophe. You might also like to drop "and" in "(magic number, version, etc.)." > The ``#'' is the number from the first line of the file > .Ar directory Ns Pa /bounds , > -and it is incremented and stored back into the file each time > -.Nm > +and is incremented and stored back into the file each time > +.Nm savecore > successfully runs. Breaking the sentences, makes the whole thing easier to understand, and removes the need for the "and" joining those two parts: The ``#'' is the number from the first line of the file .Ar directory Ns Pa /bounds . It is incremented and stored back into the file each time .Nm runs successfully. > If > +.Nm savecore > +successfully saves the core dump, and the > +.Fl k > +option is not specific, the dump's header is cleared so that future s/specific/specified/ > static void > DoFile(const char *device) > { > struct kerneldumpheader kdhf, kdhl; > - char buf[BUFSIZ]; > + char buf[BUFSIZ * 64]; Is this multiplication really necessary? Was the original buf[BUFSIZ] size not adequate? Giorgos Keramidas FreeBSD Documentation Project keramida@{freebsd.org,ceid.upatras.gr} http://www.FreeBSD.org/docproj/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message